ra/sa: Remove deprecated UpdateRegistration methods#7911
Merged
Conversation
aarongable
reviewed
Jan 7, 2025
Contributor
aarongable
left a comment
aarongable
left a comment
There was a problem hiding this comment.
LGTM with one comment on the sa test.
For now, run alongside the `fpm` build and create `boulder-newpkg-*` packages. If these packages work, we'll eliminate the `fpm` build.
Also move the ShutdownStopTimeout stanza next to timeout, and make the comment the same across the multiple components. In the future we may want to factor out some of the common config fields into a struct that can be embedded.
Remove the gates for the paused and revokedCertificates tables, which are now live and in `config`. Refine the documentation for the orderModelv2 migration.
Add mustTime and mustTimestamp, each of which parses a time in a simple format and panics if it cannot be parsed. Also, make the intent of each check in the GetRevokedCerts tests a little clearer by starting with a basicRequest, and then defining variations in terms of that request. Fix the "different issuer" case in `TestGetRevokedCerts`, which was not actually setting a different issuer.
There were a bunch of places that had `TODO(#7153)`; that issue is now closed, so let's tidy up.
Feedback from SRE was to just go straight to the new packaging. Also, fix the Architecture field of the .deb to be amd64 (Debian requires this specific value), and check that we are building on x86_64 OR amd64.
beautifulentropy
previously approved these changes
Jan 10, 2025
aarongable
requested changes
Jan 10, 2025
Co-authored-by: Aaron Gable <aaron@letsencrypt.org>
This was referenced Jan 11, 2025
aarongable
previously approved these changes
Jan 13, 2025
beautifulentropy
previously approved these changes
Jan 13, 2025
Member
beautifulentropy
left a comment
beautifulentropy
left a comment
There was a problem hiding this comment.
You have a couple of conflicts with main, happy to re-ack once those are fixed.
jprenken
dismissed stale reviews from beautifulentropy and aarongable
via
0ec0142
beautifulentropy
approved these changes
Jan 14, 2025
aarongable
approved these changes
Jan 14, 2025
Contributor
aarongable
left a comment
aarongable
left a comment
There was a problem hiding this comment.
LGTM. Make sure you spell things out a bit more in the PR description (particularly that you're deleting both implementations and gRPC methods, in both the RA and the SA, and that it's safe to do so even though the RA method calls the SA method because nothing calls the RA method anymore), and remove the "DO NOT MERGE" line from the final commit message because it's no longer relevant at that point.
jprenken
added a commit
that referenced
this pull request
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the final stage of #5554: removing the old, combined
UpdateRegistrationflow, which has been replaced byUpdateRegistrationContactandUpdateRegistrationKey. Those new functions have their own tests.The RA's
UpdateRegistrationfunction no longer has any callers (as of #7827's deployment), so it is safely deployable to remove it from the SA too, and its request from gRPC.Fixes #5554