Conversation
Alter the `LockCol` column to be nullable, so that we can stop using it.
jprenken
requested review from
beautifulentropy
and removed request for
a team
Contributor
|
@jprenken, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
Member
Contributor
Author
|
IN-10959 |
beautifulentropy
approved these changes
Jan 15, 2025
Member
beautifulentropy
left a comment
beautifulentropy
left a comment
There was a problem hiding this comment.
This looks great. A note for other reviewers: the first time I looked at this migration the ALTER COLUMN syntax caught me by surprise. I'm used to seeing MODIFY COLUMN from MySQL. But since at least MariaDB 10.2 this has been part of the broader ALTER TABLE functionality
beautifulentropy
requested review from
a team,
aarongable and
jsha
and removed request for
a team
aarongable
approved these changes
Jan 17, 2025
Contributor
aarongable
left a comment
aarongable
left a comment
There was a problem hiding this comment.
LGTM. The LockCol that used to be on the certificateStatus table had a DEFAULT 0 before we dropped it, so this makes sense as the correct step towards dropping this column entirely.
jprenken
added a commit
that referenced
this pull request
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alter the
LockColcolumn to have a default value, so we can omit it fromINSERTs.Part of #7934