Skip to content

Add critical arrays to gl interface#2490

Merged
badlogic merged 13 commits intolibgdx:masterfrom
xoppa:gl
Dec 4, 2014
Merged

Add critical arrays to gl interface#2490
badlogic merged 13 commits intolibgdx:masterfrom
xoppa:gl

Conversation

@xoppa
Copy link
Copy Markdown
Member

@xoppa xoppa commented Oct 22, 2014

This PR isn't ready for pulling yet. Having a PR makes it a bit easier on github to see and test the changes.
I accidentally included #2474 into this PR as well.

This adds optional support for java arrays instead of buffers to the GL20 interface. Leaving it up to the backend on how to translate between the java array and the opengl call. This removes the sometimes unneeded copy from java array to buffer and back.

Only added the most obvious methods (genbuffer, uniformfv, etc). I've tested the implementation of lwjgl and android (e.g. by running SkeletonTest, probably needs more testing though). I did implement, but haven't tested GWT yet. Haven't looked at the RoboVM and jglfw implementation yet.

@badlogic
Copy link
Copy Markdown
Member

Looks good so far. IOSGL20.cpp should be almost identical to the Android version. @NathanSweet is king of the JGLFW backend, you two will have to talk.

@xoppa
Copy link
Copy Markdown
Member Author

xoppa commented Oct 24, 2014

I've included the jglfw implementation and tested it as well as gwt. I've also added it for ios, but haven't tested that yet, because compiling the natives on mac doesn't work for me quite well.

@badlogic
Copy link
Copy Markdown
Member

Ok, i'll try to test iOS. Can't guarantee this will happen in the next few
days. What compilation issues do you have?
On Oct 24, 2014 11:12 PM, "Xoppa" notifications@github.com wrote:

I've included the jglfw implementation and tested it along with gwt. I've
also added it for ios, but haven't tested that yet, because compiling the
natives on mac doesn't work for me quite well.


Reply to this email directly or view it on GitHub
#2490 (comment).

@xoppa
Copy link
Copy Markdown
Member Author

xoppa commented Oct 25, 2014

I had to pull in the changes you made yesterday. It compiles now and seems to work on ios as well. We probably should do some more testing though, e.g. on a real device.

@ghost
Copy link
Copy Markdown

ghost commented Nov 11, 2014

I can only say I'm really looking forward for this PR to be merged, because usings arrays for GL is something that I really missed much in libGDX (and it's quite ubiquitous in GL wrappers for Java at the same time).

@badlogic
Copy link
Copy Markdown
Member

badlogic commented Dec 4, 2014

Awesome!

badlogic added a commit that referenced this pull request Dec 4, 2014
Add critical arrays to gl interface
@badlogic badlogic merged commit 2771725 into libgdx:master Dec 4, 2014
RotaruDan pushed a commit to RotaruDan/ead that referenced this pull request Dec 5, 2014
anserran added a commit to e-ucm/ead that referenced this pull request Dec 5, 2014
@xoppa xoppa deleted the gl branch October 15, 2015 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants