Skip to content

Introduce water fountains full sync, and update several dependencies#318

Merged
fabionl merged 41 commits into
masterfrom
develop
May 24, 2026
Merged

Introduce water fountains full sync, and update several dependencies#318
fabionl merged 41 commits into
masterfrom
develop

Conversation

@fabionl
Copy link
Copy Markdown
Collaborator

@fabionl fabionl commented May 24, 2026

No description provided.

fabionl and others added 30 commits March 15, 2026 18:18
…ill and ruby-gem-updater subagent (#266)

* instruct agents how to run rails and rspec

* update puma

* update faker

* update rack-mini-profiler

* update pry

* update sass package

* update fontawesome package

* feat(agents): add ruby-gem-update skill and a ruby-gem-updater subagent
…ans skill (#268)

* Add gem-update plan

* chore(deps): update gem dependencies

- Patch update 26 gems (bcrypt, ffi, pg, redis-client, nokogiri, etc.)
- Upgrade responders 3.1.1 → 3.2.0 (transitive of devise)
- Replace pry-remote with pry-remote-reloaded (direct Gemfile change)
- Update slop 3.6.0 → 4.10.1 (transitive of pry-remote-reloaded)
- Updated plan and tracker to better reflect actions and current progress

Note: shoulda-matchers, turbo-rails, and devise already at latest

* update gem update plan's tracker with details for upgrading pagy

* Update pagy

* Rename plan-creation skill to plans, improve the skill to correctly cover plans management, and update all docs to fix relative paths

* fix rubocop offenses
* master:
  chore: upgrade several gems, update pagy gem to v43 and reorganize plans skill (#268)
  Performs routine dependency updates and introduces ruby-gem-update skill and ruby-gem-updater subagent (#266)
  chore(opencode): add plan-creation skill with plan/tracker templates
Bumps [@hotwired/turbo](https://github.com/hotwired/turbo) from 8.0.18 to 8.0.23.
- [Release notes](https://github.com/hotwired/turbo/releases)
- [Commits](hotwired/turbo@v8.0.18...v8.0.23)

---
updated-dependencies:
- dependency-name: "@hotwired/turbo"
  dependency-version: 8.0.23
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actionpack](https://github.com/rails/rails) from 8.1.2 to 8.1.2.1.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v8.1.2.1/actionpack/CHANGELOG.md)
- [Commits](rails/rails@v8.1.2...v8.1.2.1)

---
updated-dependencies:
- dependency-name: actionpack
  dependency-version: 8.1.2.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.85.1 to 1.86.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.85.1...v1.86.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-version: 1.86.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [web-console](https://github.com/rails/web-console) from 4.2.1 to 4.3.0.
- [Release notes](https://github.com/rails/web-console/releases)
- [Changelog](https://github.com/rails/web-console/blob/main/CHANGELOG.markdown)
- [Commits](rails/web-console@v4.2.1...v4.3.0)

---
updated-dependencies:
- dependency-name: web-console
  dependency-version: 4.3.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [jquery](https://github.com/jquery/jquery) from 3.6.1 to 4.0.0.
- [Release notes](https://github.com/jquery/jquery/releases)
- [Changelog](https://github.com/jquery/jquery/blob/main/changelog.md)
- [Commits](jquery/jquery@3.6.1...4.0.0)

---
updated-dependencies:
- dependency-name: jquery
  dependency-version: 4.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [rails](https://github.com/rails/rails) from 8.1.2 to 8.1.3.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](rails/rails@v8.1.2...v8.1.3)

---
updated-dependencies:
- dependency-name: rails
  dependency-version: 8.1.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [addressable](https://github.com/sporkmonger/addressable) from 2.8.9 to 2.9.0.
- [Changelog](https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md)
- [Commits](sporkmonger/addressable@addressable-2.8.9...addressable-2.9.0)

---
updated-dependencies:
- dependency-name: addressable
  dependency-version: 2.9.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [trix](https://github.com/basecamp/trix) from 2.1.4 to 2.1.18.
- [Release notes](https://github.com/basecamp/trix/releases)
- [Commits](basecamp/trix@v2.1.4...v2.1.18)

---
updated-dependencies:
- dependency-name: trix
  dependency-version: 2.1.18
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.18.1.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.21...4.18.1)

---
updated-dependencies:
- dependency-name: lodash
  dependency-version: 4.18.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [pagy](https://github.com/ddnexus/pagy) from 43.4.2 to 43.4.4.
- [Release notes](https://github.com/ddnexus/pagy/releases)
- [Changelog](https://github.com/ddnexus/pagy/blob/master/docs/CHANGELOG.md)
- [Commits](ddnexus/pagy@43.4.2...43.4.4)

---
updated-dependencies:
- dependency-name: pagy
  dependency-version: 43.4.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@rails/activestorage](https://github.com/rails/rails) from 8.1.200 to 8.1.300.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](https://github.com/rails/rails/commits)

---
updated-dependencies:
- dependency-name: "@rails/activestorage"
  dependency-version: 8.1.300
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@hotwired/turbo-rails](https://github.com/hotwired/turbo-rails) from 8.0.18 to 8.0.23.
- [Release notes](https://github.com/hotwired/turbo-rails/releases)
- [Commits](https://github.com/hotwired/turbo-rails/commits)

---
updated-dependencies:
- dependency-name: "@hotwired/turbo-rails"
  dependency-version: 8.0.23
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@rails/request.js](https://github.com/rails/request.js) from 0.0.12 to 0.0.13.
- [Release notes](https://github.com/rails/request.js/releases)
- [Commits](rails/request.js@v0.0.12...v0.0.13)

---
updated-dependencies:
- dependency-name: "@rails/request.js"
  dependency-version: 0.0.13
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [picomatch](https://github.com/micromatch/picomatch) from 4.0.3 to 4.0.4.
- [Release notes](https://github.com/micromatch/picomatch/releases)
- [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/picomatch@4.0.3...4.0.4)

---
updated-dependencies:
- dependency-name: picomatch
  dependency-version: 4.0.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.3.3 to 3.4.0.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](cure53/DOMPurify@3.3.3...3.4.0)

---
updated-dependencies:
- dependency-name: dompurify
  dependency-version: 3.4.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.86.0 to 1.86.1.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.86.0...v1.86.1)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-version: 1.86.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@rails/actiontext](https://github.com/rails/rails) from 8.1.200 to 8.1.300.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](https://github.com/rails/rails/commits)

---
updated-dependencies:
- dependency-name: "@rails/actiontext"
  dependency-version: 8.1.300
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [pagy](https://github.com/ddnexus/pagy) from 43.5.0 to 43.5.1.
- [Release notes](https://github.com/ddnexus/pagy/releases)
- [Changelog](https://github.com/ddnexus/pagy/blob/master/docs/CHANGELOG.md)
- [Commits](ddnexus/pagy@43.5.0...43.5.1)

---
updated-dependencies:
- dependency-name: pagy
  dependency-version: 43.5.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit f05fb9e18f37b2055ee8141ac6cc3a70858dd747)
Bumps [@rails/actioncable](https://github.com/rails/rails) from 8.1.200 to 8.1.300.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](https://github.com/rails/rails/commits)

---
updated-dependencies:
- dependency-name: "@rails/actioncable"
  dependency-version: 8.1.300
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [sass](https://github.com/sass/dart-sass) from 1.98.0 to 1.99.0.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](sass/dart-sass@1.98.0...1.99.0)

---
updated-dependencies:
- dependency-name: sass
  dependency-version: 1.99.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [listen](https://github.com/guard/listen) from 3.9.0 to 3.10.0.
- [Release notes](https://github.com/guard/listen/releases)
- [Commits](guard/listen@v3.9.0...v3.10.0)

---
updated-dependencies:
- dependency-name: listen
  dependency-version: 3.10.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [propshaft](https://github.com/rails/propshaft) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/rails/propshaft/releases)
- [Commits](rails/propshaft@v1.3.1...v1.3.2)

---
updated-dependencies:
- dependency-name: propshaft
  dependency-version: 1.3.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
fabionl and others added 11 commits May 24, 2026 10:47
…d purge support

- Add soft-delete for facilities absent from API response (enabled by default)
- Sync now undeletes and updates previously soft-deleted facilities
- New admin purge action to remove all water fountains for a given API
- Enhanced Syncer.call result with created_count, updated_count, deleted_count
… result tracking

- Introduce External::SyncOperations domain object for explicit operation tracking (create, external_update, internal_update, discard)
- Extract API record parsing logic into a reusable External::VancouverCity::FacilityMapper service
- Update FacilityBuilder to accept existing facility instances and delegate attribute assignment to the mapper
- Refactor FacilitySyncer to accept an explicit operation parameter and handle transactional record saves
- Replace monolithic DiscardService with granular FacilityDiscarder to enable per-facility error handling and logging
- Enhance Syncer to aggregate SyncResultDataEntry per operation, supporting partial failures and detailed success/failure counts
- Add inverse_of and autosave associations to Facility and related models to improve transactional integrity
- Improve Admin::ToolsController to gracefully handle and report partial sync/discard failures to the user
- Update specs to align with new service signatures, result structures, and modernized mocking strategies
- Fix DiscardReasonComponent to correctly handle and render nil discard reasons
- Update system specs to use login_as helper and fix page object interaction methods
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.19.2 to 1.19.3.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.19.2...v1.19.3)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-version: 1.19.3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [trix](https://github.com/basecamp/trix) from 2.1.18 to 2.1.19.
- [Release notes](https://github.com/basecamp/trix/releases)
- [Commits](basecamp/trix@v2.1.18...v2.1.19)

---
updated-dependencies:
- dependency-name: trix
  dependency-version: 2.1.19
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [faraday](https://github.com/lostisland/faraday) from 2.14.1 to 2.14.2.
- [Release notes](https://github.com/lostisland/faraday/releases)
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md)
- [Commits](lostisland/faraday@v2.14.1...v2.14.2)

---
updated-dependencies:
- dependency-name: faraday
  dependency-version: 2.14.2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@fabionl fabionl merged commit d951e23 into master May 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant