chore: [M3-7231] - Migrate Filesystem TextField Select to Autocomplete#9752
Merged
bnussman-akamai merged 3 commits intolinode:developfrom Oct 4, 2023
Conversation
bnussman-akamai
requested review from
coliu-akamai and
dwiley-akamai
and removed request for
a team
bnussman-akamai
changed the title
bnussman-akamai
changed the title
abailly-akamai
approved these changes
Oct 4, 2023
Contributor
abailly-akamai
left a comment
abailly-akamai
left a comment
There was a problem hiding this comment.
Nice!
- look and feel - no regression ✅
- functionality - request succeeded and UI updated ✅
jdamore-linode
approved these changes
Oct 4, 2023
Contributor
jdamore-linode
left a comment
jdamore-linode
left a comment
There was a problem hiding this comment.
Thanks @bnussman-akamai!
Followed your testing steps and everything looked good! Confirmed that the storage e2e tests continue to pass (I'm not sure the "Add a Disk" drawer has any coverage so that was probably unnecessary), and also reviewed the CI test results -- 3 of the failures were DBaaS, and the other was a test which has been flaky lately (and which I confirmed is passing locally) so those failures can be disregarded when it comes time to merge.
coliu-akamai
approved these changes
Oct 4, 2023
Contributor
coliu-akamai
left a comment
coliu-akamai
left a comment
There was a problem hiding this comment.
Walked through the listed steps +
✅ Confirmed that post request was sent
✅ confirmed that UI is updated with autocomplete (+ looks and feels a lot cleaner!)
🎉
This was referenced Oct 4, 2023
This was referenced Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
In order to fix up our TextField component, we need to not allow it to be used as a select component. This PR replaces the TextField Select in CreateDiskDrawer with a modern alternative like Autocomplete
Preview 📷
How to test 🧪
StoragetabAdd DiskFilesystemselect functionality