refactor: [M3-7229] - Migrate UserDefinedSelect from a TextField Select to an Autocomplete#9756
Merged
bnussman-akamai merged 3 commits intolinode:developfrom Oct 12, 2023
Conversation
bnussman-akamai
requested review from
cliu-akamai and
cpathipa
and removed request for
a team
cpathipa
approved these changes
Oct 6, 2023
Contributor
cpathipa
left a comment
cpathipa
left a comment
There was a problem hiding this comment.
LGTM! Confirming on Marketplace App Select Components are working as expected.
…xtfield-to-autocomplete
abailly-akamai
approved these changes
Oct 12, 2023
Contributor
abailly-akamai
left a comment
abailly-akamai
left a comment
There was a problem hiding this comment.
Thanks!
- No visual regression
- No functional regression
This was referenced Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Preview 📷
How to test 🧪
Player Idle Timeoutis selectable and shows the selected value (playeridletimeout) when the LinodePOSThappens