refactor: [M3-7230] - Migrate NodeBalancer Node Mode Select TextField to Autocomplete#9754
Merged
bnussman-akamai merged 7 commits intolinode:developfrom Oct 12, 2023
Conversation
hana-akamai
requested changes
Oct 5, 2023
Contributor
hana-akamai
left a comment
There was a problem hiding this comment.
Looks like removing a Backend Node broke 🤔
Screen.Recording.2023-10-05.at.5.03.23.PM.mov
…from-textfield-to-autocomplete
Member
Author
|
@hana-linode Thank you! Fixed in eb9667a |
hana-akamai
approved these changes
Oct 6, 2023
Contributor
hana-akamai
left a comment
There was a problem hiding this comment.
Confirmed that the Mode select still looks and works as expected and that remove still works 🎉
packages/manager/src/features/NodeBalancers/NodeBalancerConfigNode.tsx
Outdated
Show resolved
Hide resolved
…from-textfield-to-autocomplete
jdamore-linode
approved these changes
Oct 12, 2023
Contributor
jdamore-linode
left a comment
There was a problem hiding this comment.
Thanks @bnussman-akamai! Confirmed that the autocomplete field works/looks as expected and that I can add/remove nodes. Also confirmed that I can actually save the config changes
This was referenced Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Major Changes 🔄
Removebutton styles<TextField select>...</TextField>with an<Autocomplete />Preview 📷
How to test 🧪
ModeSelect