Skip to content

fix(jobs): internal platform to nango-integration mapping - #3605

Merged
mbani01 merged 2 commits into
mainfrom
fix/nango_monitor_job
Nov 17, 2025
Merged

fix(jobs): internal platform to nango-integration mapping#3605
mbani01 merged 2 commits into
mainfrom
fix/nango_monitor_job

Conversation

@mbani01

@mbani01 mbani01 commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

This pull request updates the logic for determining the Nango integration name when checking the connection status in the nangoMonitoring.job.ts cron job. Instead of using a conditional inline check, it now delegates this responsibility to the platformToNangoIntegration helper function, which takes both int.platform and int.settings as arguments. This change should improve code readability and maintainability.

  • Refactored the Nango integration name selection logic to use the platformToNangoIntegration helper function in nangoMonitoring.job.ts, replacing the previous inline conditional.

@mbani01
mbani01 requested a review from themarolt November 17, 2025 11:18
@mbani01 mbani01 self-assigned this Nov 17, 2025
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@mbani01
mbani01 merged commit 455e445 into main Nov 17, 2025
13 checks passed
@mbani01
mbani01 deleted the fix/nango_monitor_job branch November 17, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants