Revert "Manual chery-pick: [OTBN] Integrate compression option for imem and dmem"#30536
Merged
Merged
Conversation
luismarques
requested review from
a team,
jwnrt,
moidx,
pamaury and
siemen11
and removed request for
a team
siemen11
approved these changes
Jun 30, 2026
siemen11
left a comment
siemen11
left a comment
Contributor
There was a problem hiding this comment.
Thanks Luiz, I will try get it back in after the upgrade
luismarques
force-pushed
the
revert-30472-cherry_pick_compression
branch
from
111ffe7 to
42c6af9
Compare
luismarques
force-pushed
the
revert-30472-cherry_pick_compression
branch
from
42c6af9 to
2b27207
Compare
Contributor
|
Building all the OTBN apps now throws the same warning because we link executables with LD. Do we need to change how we build them? |
Contributor
Author
I think @siemen11 is planning on reworking the compression feature to avoid the problematic linker use. So, this PR will remove the warnings from master, and the rework will eventually remove the warnings from the 1.0 branch. We can then also cherry-pick the reworked approach to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #30472. Relinking an executable file with LD was deprecated and support for that has now been removed. That prevents upgrading the toolchain.