PayPal PayFlow Pro: "Comment 1" field set incorrectly

[dccampbell]

Description

PayPal PayFlow provides the optional COMMENT1 field for passing along any custom information desired to be saved with the transaction in PayPal (documentation here).

Magento 2 attempts to use this field to store the order ID. However, the use of setComment1() to add this value to the request creates the key comment_1 rather than comment1. As such, PayPal ignores it and so the field appears empty when viewing PayPal transactions.

Preconditions

• Magento version >= 2.3.3*
• PayPal Payflow Pro payment method is enabled and working

*Confirmed in these versions, but also affects all previous M2 releases assuming that the parsing of setData magic method names wasn't changed at some point.

Steps to reproduce

• Complete any order using PayPal Payflow Pro as the payment method.

Expected result

• When viewing the transaction for the order in PayPal, the "Comment 1" field contains the order ID.

Actual result

• The "Comment 1" field is missing/empty on the transaction.

Proposed Resolution

magento2/app/code/Magento/Paypal/Model/Payflowpro.php

Line 885 in 9c14af7

->setComment1($orderIncrementId);

Change the ->setComment1($orderIncrementId); line to ->setData('comment1', $orderIncrementId);

That's assuming that a numeral being treated like a capital letter here when converting camelCase set method names to snake_case data keys is not itself a bigger issue. If not, I'm happy to submit a pull request for the above change if desired.

[engcom-backlog-nickolas]

Hello @dccampbell, thank you for your report.
We've acknowledged the issue and added to our backlog.

[magento-engcom-team]

Hi @milindsingh. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

[magento-engcom-team]

Hi @adityayadav-cedcoss. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

[realadityayadav]

#MM19IN