Skip to content

Conversation

@chandru-199
Copy link
Contributor

@chandru-199 chandru-199 commented May 11, 2020

Description (*)

Fixed the issue that running bin/magento setup:upgrade re-enables layout, block_html and full_page caches.

Fixed Issues (if relevant)

Related Pull Requests

NA

Manual testing scenarios (*)

  1. Disable cache types layout, block_html and full_page by running bin/magento cache:disable block_html full_page layout.
  2. Run bin/magento s:up.
  3. Enabling caches message displays in cli output and layout, block_html and full_page caches are enabled.
  4. Expected result is those cache types should be disabled.

Enabling caches: Current status: Array ( [layout] => 1 [block_html] => 1 [full_page] => 1 )

Questions or comments

NA

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Status of cache types changed after running setup:upgrade #29588: Status of cache types changed after running setup:upgrade

@m2-assistant
Copy link

m2-assistant bot commented May 11, 2020

Hi @chandru-199. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@chandru-199
Copy link
Contributor Author

@magento run all tests

@orthener
Copy link

How to create patch for this?

@sidolov
Copy link
Contributor

sidolov commented Aug 17, 2020

@magento create issue

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 17, 2020
@ihor-sviziev ihor-sviziev self-assigned this Aug 27, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev
Copy link
Contributor

Hi @chandru-199,
I found that we actually have another solution for the same issue #28491 and it seems to me better.
I'm closing this PR as we have better solution. Thank you for contribution!

@m2-assistant
Copy link

m2-assistant bot commented Aug 27, 2020

Hi @chandru-199, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Setup Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: pending review Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Projects

None yet

5 participants