Skip to content

MNT: Refactor matplotlib.colors.from_levels_and_colors() #29127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuLogic merged 1 commit into from
Nov 13, 2024
Merged

MNT: Refactor matplotlib.colors.from_levels_and_colors() #29127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions lib/matplotlib/colors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3690,23 +3690,19 @@ def from_levels_and_colors(levels, colors, extend='neither'):
color_slice = slice_map[extend]

n_data_colors = len(levels) - 1
n_expected = n_data_colors + color_slice.start - (color_slice.stop or 0)
n_extend_colors = color_slice.start - (color_slice.stop or 0) # 0, 1 or 2
n_expected = n_data_colors + n_extend_colors
if len(colors) != n_expected:
raise ValueError(
f'With extend == {extend!r} and {len(levels)} levels, '
f'expected {n_expected} colors, but got {len(colors)}')

cmap = ListedColormap(colors[color_slice], N=n_data_colors)

if extend in ['min', 'both']:
cmap.set_under(colors[0])
else:
cmap.set_under('none')

if extend in ['max', 'both']:
cmap.set_over(colors[-1])
else:
cmap.set_over('none')
f'Expected {n_expected} colors ({n_data_colors} colors for {len(levels)} '
f'levels, and {n_extend_colors} colors for extend == {extend!r}), '
f'but got {len(colors)}')

data_colors = colors[color_slice]
under_color = colors[0] if extend in ['min', 'both'] else 'none'
over_color = colors[-1] if extend in ['max', 'both'] else 'none'
cmap = ListedColormap(data_colors).with_extremes(
under=under_color, over=over_color)

cmap.colorbar_extend = extend

Expand Down