This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Merged
Conversation
Member
|
Can one of the admins verify this patch? |
4 similar comments
Member
|
Can one of the admins verify this patch? |
Member
|
Can one of the admins verify this patch? |
Member
|
Can one of the admins verify this patch? |
Member
|
Can one of the admins verify this patch? |
richvdh
suggested changes
Dec 5, 2016
tests/test_preview.py
Outdated
Member
There was a problem hiding this comment.
think this has got lost. also a few below.
Contributor
Author
There was a problem hiding this comment.
Gah, d'oh, to greedy of a regex, sorry about that, fixed now.
Member
|
matrixbot: ok to test |
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
The old test expected an incorrect wrapping due to the preview function not using unicode properly, so it got the wrong length. Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
kyrias
force-pushed
the
fix-preview-test
branch
from
a6e1d8f to
6c9a0ba
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes test issues raised in #1664.