Skip to content

fix(resources): correct LilyGo T5 S3 ePaper targets - #114

Draft
agentkekbot wants to merge 1 commit into
meshtastic:masterfrom
agentkekbot:fix/t5s3-hardware-catalog
Draft

fix(resources): correct LilyGo T5 S3 ePaper targets#114
agentkekbot wants to merge 1 commit into
meshtastic:masterfrom
agentkekbot:fix/t5s3-hardware-catalog

Conversation

@agentkekbot

@agentkekbot agentkekbot commented Aug 7, 2026

Copy link
Copy Markdown

Depends on meshtastic/firmware#11368 for runtime identity and release artifact metadata.

Summary

Replace the stale generic model-123 catalog record with target-specific inactive records for:

  • t5s3-epaper-v2 — H752-01 V2, listed first with the canonical family display name
  • t5s3-epaper-v1 — H752 V1
  • t5s3_epaper_inkhud — H752-01 V2 InkHUD

The records retain the existing hardware model 123, correct the partition scheme from 8 MB to 16 MB, and identify the real PlatformIO environments and revisions. They intentionally remain inactive until physical validation and release-artifact availability are confirmed.

The V2 record is intentionally first and uses the family display name. Mesh DeviceMetadata carries only hwModel = 123, not the PlatformIO target. Android falls back to catalog order and Apple resolves duplicate-model records deterministically, so this avoids mislabeling current H752-01 nodes as V1 while keeping exact revisions available in catalog metadata.

The exact t5s3_epaper_inkhud record intentionally does not set hasInkHud. In the Web Flasher that field means “append -inkhud to a base target”; setting it here would produce the nonexistent t5s3_epaper_inkhud-inkhud target.

Downstream propagation

The Web Flasher hardware list is a protected generated file synchronized from this API every six hours. Android and Apple bundle the same API catalog through scheduled sync workflows, so direct app/flasher edits are intentionally omitted.

Validation

  • frozen-lockfile install with pnpm 10 / Node 22
  • Biome check passed
  • Prisma generation and TypeScript build passed
  • validation script confirms exactly three unique model-123 target records, 16 MB metadata, inactive support state, canonical client fallback ordering, and no InkHUD double-suffix flag

@CLAassistant

CLAassistant commented Aug 7, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7454f183-e207-4ce8-bd30-2feae9bb8cfe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@agentkekbot
agentkekbot force-pushed the fix/t5s3-hardware-catalog branch from 7282952 to 6a499f0 Compare August 7, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants