Skip to content

fix(esp32): identify LilyGo T5 S3 ePaper Pro targets - #11368

Draft
agentkekbot wants to merge 1 commit into
meshtastic:developfrom
agentkekbot:fix/t5s3-hardware-identity
Draft

fix(esp32): identify LilyGo T5 S3 ePaper Pro targets#11368
agentkekbot wants to merge 1 commit into
meshtastic:developfrom
agentkekbot:fix/t5s3-hardware-identity

Conversation

@agentkekbot

@agentkekbot agentkekbot commented Aug 7, 2026

Copy link
Copy Markdown

Summary

  • map T5_S3_EPAPER_PRO to the existing protobuf HardwareModel value 123
  • remove the PRIVATE_HW fallback from all three T5 S3 builds
  • publish target-specific manifest metadata for H752 V1, H752-01 V2, and H752-01 V2 InkHUD
  • include the build-validated InkHUD environment in the release artifact matrix
  • keep all three records activelySupported = false until each target has the required physical validation

Why

The protobuf has defined T5_S3_EPAPER_PRO = 123 for both hardware revisions since January 2026, but the ESP32 hardware mapping was never added. The common variant continued to define PRIVATE_HW, so devices reported model 255. The generated manifests also lacked correct model, target, revision, and 16 MB metadata.

Validation

  • pio run -e t5s3-epaper-v1 -e t5s3-epaper-v2 -e t5s3_epaper_inkhud: all three succeeded
  • application and factory images validated by esptool as ESP32-S3, 16 MB, valid checksum
  • generated manifests report model 123 and the correct target/variant/partition metadata
  • generated release matrix contains all three targets
  • H752-01 InkHUD baseline was previously validated on physical hardware
  • the current identity build remains inactive pending final on-device confirmation

Compatibility

No protobuf values or partition layout are changed. Existing settings, channels, keys, node identity, and node database remain intact. Cached peer/app hardware metadata updates through subsequent NodeInfo traffic.

@CLAassistant

CLAassistant commented Aug 7, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 654f653e-8220-4656-bf97-234c214842c1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@agentkekbot, Welcome to Meshtastic!

Thanks for opening your first pull request. We really appreciate it.

We discuss work as a team in discord, please join us in the #firmware channel.
There's a big backlog of patches at the moment. If you have time,
please help us with some code review and testing of other PRs!

Welcome to the team 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants