fix(esp32): identify LilyGo T5 S3 ePaper Pro targets - #11368
Conversation
|
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@agentkekbot, Welcome to Meshtastic!Thanks for opening your first pull request. We really appreciate it. We discuss work as a team in discord, please join us in the #firmware channel. Welcome to the team 😄 |
5334bfd to
1deefaf
Compare
Summary
T5_S3_EPAPER_PROto the existing protobufHardwareModelvalue 123PRIVATE_HWfallback from all three T5 S3 buildsactivelySupported = falseuntil each target has the required physical validationWhy
The protobuf has defined
T5_S3_EPAPER_PRO = 123for both hardware revisions since January 2026, but the ESP32 hardware mapping was never added. The common variant continued to definePRIVATE_HW, so devices reported model 255. The generated manifests also lacked correct model, target, revision, and 16 MB metadata.Validation
pio run -e t5s3-epaper-v1 -e t5s3-epaper-v2 -e t5s3_epaper_inkhud: all three succeededCompatibility
No protobuf values or partition layout are changed. Existing settings, channels, keys, node identity, and node database remain intact. Cached peer/app hardware metadata updates through subsequent NodeInfo traffic.