Skip to content

Exit rmw_wait without session _run - #171

Merged
Acuadros95 merged 3 commits into
galacticfrom
fix/empty_wait
Sep 27, 2021
Merged

Exit rmw_wait without session _run#171
Acuadros95 merged 3 commits into
galacticfrom
fix/empty_wait

Conversation

@Acuadros95

@Acuadros95 Acuadros95 commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@Acuadros95
Acuadros95 requested a review from pablogs9 September 23, 2021 13:56
@github-actions

github-actions Bot commented Sep 23, 2021

Copy link
Copy Markdown

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity Qty Size per unit
Context 1 5592 B
Topic 8 56 B
Service 4 80 B
Client 4 80 B
Subscription 4 168 B
Publisher 4 184 B
Node 4 56 B
Static input buffer 8 2120 B

TOTAL: 25052 B

pablogs9
pablogs9 reviewed Sep 27, 2021
View reviewed changes
Comment thread rmw_microxrcedds_c/src/rmw_client.c
#else
char req_type_name[RMW_UXRCE_TYPE_NAME_MAX_LENGTH];
char res_type_name[RMW_UXRCE_TYPE_NAME_MAX_LENGTH];
static char req_type_name[RMW_UXRCE_TYPE_NAME_MAX_LENGTH];

@pablogs9 pablogs9 Sep 27, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment
This makes this function not reentrant but since all RCL entity creation API is not thread-safe, it is ok by now.

@pablogs9

pablogs9 commented Sep 27, 2021

Copy link
Copy Markdown
Member

@mergify backport foxy main

@mergify

mergify Bot commented Sep 27, 2021

Copy link
Copy Markdown
Contributor

Command backport foxy main: pending

backport foxy main is pending

Hey, I reacted but my real name is @Mergifyio

@Acuadros95
Acuadros95 merged commit 945c000 into galactic Sep 27, 2021
@Acuadros95
Acuadros95 deleted the fix/empty_wait branch September 27, 2021 14:14
mergify Bot pushed a commit that referenced this pull request Sep 27, 2021
@Acuadros95 mergify-bot
Exit rmw_wait without session _run (#171)
d601dd3 
* Modify char array to static

* Exit rmw_wait if no items

* Uncrustify

(cherry picked from commit 945c000)
@mergify mergify Bot mentioned this pull request Sep 27, 2021
Merged
mergify Bot pushed a commit that referenced this pull request Sep 27, 2021
@Acuadros95 mergify-bot
Exit rmw_wait without session _run (#171)
944f77a 
* Modify char array to static

* Exit rmw_wait if no items

* Uncrustify

(cherry picked from commit 945c000)
@mergify mergify Bot mentioned this pull request Sep 27, 2021
Merged
@mergify

mergify Bot commented Sep 27, 2021

Copy link
Copy Markdown
Contributor

Command backport foxy main: success

Backports have been created

Acuadros95 added a commit that referenced this pull request Sep 27, 2021
@mergify @Acuadros95
Exit rmw_wait without session _run (#171) (#172)
a067628 
* Modify char array to static

* Exit rmw_wait if no items

* Uncrustify

(cherry picked from commit 945c000)

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
Acuadros95 added a commit that referenced this pull request Sep 27, 2021
@mergify @Acuadros95
Exit rmw_wait without session _run (#171) (#173)
66a626c 
* Modify char array to static

* Exit rmw_wait if no items

* Uncrustify

(cherry picked from commit 945c000)

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogs9 pablogs9 pablogs9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Acuadros95 @pablogs9