Fix converting from a python script #8699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8699 +/- ##
==========================================
- Coverage 59.17% 58.85% -0.32%
==========================================
Files 521 521
Lines 23981 23984 +3
Branches 3874 3869 -5
==========================================
- Hits 14190 14116 -74
- Misses 8874 8951 +77
Partials 917 917
Continue to review full report at Codecov.
|
DonJayamanne
approved these changes
Nov 20, 2019
| } else { | ||
| return undefined; | ||
| } | ||
| } catch (e) { |
There was a problem hiding this comment.
IMHO, in this situation, it's better to have the python script be output instead of breaking the user's conversion. Plus it makes the test pass.
rchiodo
added a commit
that referenced
this pull request
Nov 21, 2019
* Fix converting from a python script * Fix linter error
karthiknadig
added a commit
that referenced
this pull request
Nov 27, 2019
* Ensure we run PR, CI pipelines on release branches (#8471) (#8474) * Port blue icon and altair background fixes into release (#8470) * fix blue color on export icon (#8449) * default non-text mimetypes to white background (#8452) * Fix cells being erased when saving and then changing focus to another… (#8482) (#8485) * Fix cells being erased when saving and then changing focus to another cell * Make sure to use the source even if it's empty * Fix timeout to be what it was before. 10 seconds isn't long enough (#8504) * Ensure wheels experiment control and experiment groups uses right wheel (#8461) (#8546) * Ensure wheels control group uses no wheel ptvsd * Improve condition readability in jupyter debugger * Adjust debug adapter experiment before release (#8540) (#8553) * Release branch: updating change log and package json (#8570) * Change version numbers * Update package lock json * Update changelog * Fix for 7999 - CTRL+Z should not undo at the top level (#8571) * Fix arrowing up and down to save code too (#8574) * Prompt selecting a file to save once (#8590) * Prompt selecting a file to save once * Better algorithm * After pasting code, arrow keys don't navigate in a cell. (#8587) * Don't look for a jupyter interpreter when creating blank notebook (#8596) * Creating a new blank notebook should not require a search for jupyter. * Fix bug caused by other fix. * Update change log * Update release date in change log (#8604) * Fix converting from a python script (#8699) * Fix converting from a python script * Fix linter error * Fix problem with $$ not being put around the correct items in a LaTeX equation (#8707) * First try * Add news entry and fix multiples * Add a bunch of comments * Modify changelog and version number * Fixes to starting Jupyter in a Docker container. (#8715) * Ensure we generate the right args when running in docker * Fixes to starting `Jupyter` in a `Docker` container. * Ensure arguments are generated correctly for `getRemoteLauncherCommand` when in debugger experiment (#8712) * Return new debugger arguments when in experiment * Add news item * Updates to change log * Revert tests due to incompatibilities
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8677