Fix problem with $$ not being put around the correct items in a LaTeX equation #8707

rchiodo · 2019-11-21T01:22:43Z

For #8673

Added a bunch of unit tests (in particular the one that was failing).

rchiodo · 2019-11-21T01:23:25Z

src/test/datascience/latexManipulation.unit.test.ts

 `;

-    test('Latex - Equations don\'t have $$', () => {
+    const markdown4 = `


THis is the one that was failing in the bug

Tip you can use dedent to indent code,
(its more reliable and avoids issues when code gets accidentally indented).
check

vscode-python/src/test/common/process/pythonDaemon.functional.test.ts

Lines 124 to 134 in 85b828e

test('Execute a file and capture stdout (with unicode)', async () => {

const source = dedent`

import sys

sys.stdout.write("HELLO WORLD-₹-😄")

`;

const fileToExecute = await createPythonFile(source);

const output = await pythonDaemon.exec([fileToExecute], {});

assert.isUndefined(output.stderr);

assert.deepEqual(output.stdout, 'HELLO WORLD-₹-😄');

});

rchiodo · 2019-11-21T01:23:53Z

src/datascience-ui/interactive-common/latexManipulation.ts

-            const endOfEnd = input.indexOf('}', endIndexes[i] + 1 + 8 * i);
+    // Loop until we run out string
+    while (start < input.length) {
+        // Check $$, $ and begin


Hmm, maybe I'll put a more general comment about the algorithm being used.

Even after reading the comments, its quite complicated. I guess there's nothing we can do about that...

codecov-io · 2019-11-21T01:44:19Z

Codecov Report

Merging #8707 into master will decrease coverage by 0.26%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #8707      +/-   ##
=========================================
- Coverage   59.17%   58.9%   -0.27%     
=========================================
  Files         521     521              
  Lines       23985   24010      +25     
  Branches     3874    3874              
=========================================
- Hits        14192   14143      -49     
- Misses       8876    8951      +75     
+ Partials      917     916       -1

Impacted Files	Coverage Δ
...science-ui/interactive-common/latexManipulation.ts	`100% <100%> (+6.25%)`	⬆️
src/client/testing/serviceRegistry.ts	`48.64% <0%> (-46.85%)`	⬇️
src/client/testing/codeLenses/main.ts	`44.44% <0%> (-33.34%)`	⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts	`66.66% <0%> (-33.34%)`	⬇️
src/client/formatters/serviceRegistry.ts	`75% <0%> (-25%)`	⬇️
...ience/jupyter/jupyterDebuggerRemoteNotSupported.ts	`75% <0%> (-25%)`	⬇️
...cience/jupyter/jupyterDebuggerNotInstalledError.ts	`60% <0%> (-20%)`	⬇️
src/client/common/utils/icons.ts	`83.33% <0%> (-16.67%)`	⬇️
src/client/api.ts	`78.57% <0%> (-14.29%)`	⬇️
src/client/datascience/cellFactory.ts	`57.69% <0%> (-12.83%)`	⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1782b75...cbe8af3. Read the comment docs.

DonJayamanne · 2019-11-21T02:34:52Z

src/datascience-ui/interactive-common/latexManipulation.ts

-            const endOfEnd = input.indexOf('}', endIndexes[i] + 1 + 8 * i);
+    // Loop until we run out string
+    while (start < input.length) {
+        // Check $$, $ and begin


Even after reading the comments, its quite complicated. I guess there's nothing we can do about that...

DonJayamanne · 2019-11-21T02:38:31Z

src/test/datascience/latexManipulation.unit.test.ts

 `;

-    test('Latex - Equations don\'t have $$', () => {
+    const markdown4 = `


Tip you can use dedent to indent code,
(its more reliable and avoids issues when code gets accidentally indented).
check

vscode-python/src/test/common/process/pythonDaemon.functional.test.ts

Lines 124 to 134 in 85b828e

test('Execute a file and capture stdout (with unicode)', async () => {

const source = dedent`

import sys

sys.stdout.write("HELLO WORLD-₹-😄")

`;

const fileToExecute = await createPythonFile(source);

const output = await pythonDaemon.exec([fileToExecute], {});

assert.isUndefined(output.stderr);

assert.deepEqual(output.stdout, 'HELLO WORLD-₹-😄');

});

… equation (#8707) * First try * Add news entry and fix multiples * Add a bunch of comments

* Ensure we run PR, CI pipelines on release branches (#8471) (#8474) * Port blue icon and altair background fixes into release (#8470) * fix blue color on export icon (#8449) * default non-text mimetypes to white background (#8452) * Fix cells being erased when saving and then changing focus to another… (#8482) (#8485) * Fix cells being erased when saving and then changing focus to another cell * Make sure to use the source even if it's empty * Fix timeout to be what it was before. 10 seconds isn't long enough (#8504) * Ensure wheels experiment control and experiment groups uses right wheel (#8461) (#8546) * Ensure wheels control group uses no wheel ptvsd * Improve condition readability in jupyter debugger * Adjust debug adapter experiment before release (#8540) (#8553) * Release branch: updating change log and package json (#8570) * Change version numbers * Update package lock json * Update changelog * Fix for 7999 - CTRL+Z should not undo at the top level (#8571) * Fix arrowing up and down to save code too (#8574) * Prompt selecting a file to save once (#8590) * Prompt selecting a file to save once * Better algorithm * After pasting code, arrow keys don't navigate in a cell. (#8587) * Don't look for a jupyter interpreter when creating blank notebook (#8596) * Creating a new blank notebook should not require a search for jupyter. * Fix bug caused by other fix. * Update change log * Update release date in change log (#8604) * Fix converting from a python script (#8699) * Fix converting from a python script * Fix linter error * Fix problem with $$ not being put around the correct items in a LaTeX equation (#8707) * First try * Add news entry and fix multiples * Add a bunch of comments * Modify changelog and version number * Fixes to starting Jupyter in a Docker container. (#8715) * Ensure we generate the right args when running in docker * Fixes to starting `Jupyter` in a `Docker` container. * Ensure arguments are generated correctly for `getRemoteLauncherCommand` when in debugger experiment (#8712) * Return new debugger arguments when in experiment * Add news item * Updates to change log * Revert tests due to incompatibilities

rchiodo added 2 commits November 20, 2019 16:44

First try

ebc188e

Add news entry and fix multiples

3830e00

rchiodo requested review from DavidKutu, DonJayamanne and IanMatthewHuff November 21, 2019 01:22

rchiodo self-assigned this Nov 21, 2019

rchiodo commented Nov 21, 2019

View reviewed changes

Add a bunch of comments

cbe8af3

DonJayamanne approved these changes Nov 21, 2019

View reviewed changes

rchiodo merged commit 00e0472 into master Nov 21, 2019

rchiodo deleted the rchiodo/mathjax_conversion branch November 21, 2019 16:24

rchiodo added a commit that referenced this pull request Nov 21, 2019

Fix problem with $$ not being put around the correct items in a LaTeX…

fa999f7

… equation (#8707) * First try * Add news entry and fix multiples * Add a bunch of comments

lock bot locked as resolved and limited conversation to collaborators Nov 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix problem with $$ not being put around the correct items in a LaTeX equation #8707

Fix problem with $$ not being put around the correct items in a LaTeX equation #8707

Uh oh!

rchiodo commented Nov 21, 2019

Uh oh!

rchiodo Nov 21, 2019

Uh oh!

DonJayamanne Nov 21, 2019

Uh oh!

rchiodo Nov 21, 2019

Uh oh!

DonJayamanne Nov 21, 2019

Uh oh!

codecov-io commented Nov 21, 2019 •

edited

Loading

Uh oh!

DonJayamanne Nov 21, 2019

Uh oh!

DonJayamanne Nov 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	test('Execute a file and capture stdout (with unicode)', async () => {
	const source = dedent`
	import sys
	sys.stdout.write("HELLO WORLD-₹-😄")
	`;
	const fileToExecute = await createPythonFile(source);
	const output = await pythonDaemon.exec([fileToExecute], {});

	assert.isUndefined(output.stderr);
	assert.deepEqual(output.stdout, 'HELLO WORLD-₹-😄');
	});

Fix problem with $$ not being put around the correct items in a LaTeX equation #8707

Fix problem with $$ not being put around the correct items in a LaTeX equation #8707

Uh oh!

Conversation

rchiodo commented Nov 21, 2019

Uh oh!

rchiodo Nov 21, 2019

Choose a reason for hiding this comment

Uh oh!

DonJayamanne Nov 21, 2019

Choose a reason for hiding this comment

Uh oh!

rchiodo Nov 21, 2019

Choose a reason for hiding this comment

Uh oh!

DonJayamanne Nov 21, 2019

Choose a reason for hiding this comment

Uh oh!

codecov-io commented Nov 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DonJayamanne Nov 21, 2019

Choose a reason for hiding this comment

Uh oh!

DonJayamanne Nov 21, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-io commented Nov 21, 2019 •

edited

Loading