Skip to content

Conversation

@pratik-a
Copy link
Contributor

No description provided.

@kevinAlbs
Copy link
Collaborator

Thank you for the contribution @pratik-a!

@codecov-commenter
Copy link

Codecov Report

Merging #820 (f9c1368) into master (401ad6b) will decrease coverage by 0.66%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
- Coverage   91.31%   90.64%   -0.67%     
==========================================
  Files         381      381              
  Lines       22028    22029       +1     
==========================================
- Hits        20114    19969     -145     
- Misses       1914     2060     +146     
Impacted Files Coverage Δ
src/bsoncxx/types/bson_value/view.cpp 82.22% <0.00%> (-1.87%) ⬇️
src/mongocxx/pool.cpp 60.78% <0.00%> (-9.81%) ⬇️
src/mongocxx/test_util/client_helpers.cpp 82.90% <0.00%> (-5.56%) ⬇️
src/mongocxx/test/collection.cpp 93.56% <0.00%> (-4.16%) ⬇️
src/mongocxx/test/spec/change_stream.cpp 94.44% <0.00%> (-3.34%) ⬇️
src/mongocxx/test/change_streams.cpp 94.83% <0.00%> (-3.15%) ⬇️
src/mongocxx/test/client_side_encryption.cpp 94.48% <0.00%> (-2.42%) ⬇️
src/mongocxx/test/sdam-monitoring.cpp 94.70% <0.00%> (-1.99%) ⬇️
src/mongocxx/test/transactions.cpp 74.03% <0.00%> (-1.56%) ⬇️
src/mongocxx/test/index_view.cpp 97.49% <0.00%> (-1.44%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 401ad6b...f9c1368. Read the comment docs.

@kevinAlbs kevinAlbs self-requested a review September 2, 2021 13:46
@kevinAlbs kevinAlbs requested review from chardan and removed request for kevinAlbs September 13, 2021 19:14
Copy link
Contributor

@chardan chardan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks ok to me!

break;
#include <bsoncxx/enums/type.hpp>
#undef BSONCXX_ENUM
default : break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: I think this is fine and will do what you want; consider also moving it ahead of the include-pasted cases, so that the latter will be indicated as an error instead of your more intentional case. (And, I think it's slightly easier to read, YYMV.)

@chardan chardan merged commit 3b27f8d into mongodb:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants