Skip to content

default added #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2021
Merged

default added #820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/bsoncxx/types/bson_value/view.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ view& view::operator=(const view& rhs) noexcept {
break;
#include <bsoncxx/enums/type.hpp>
#undef BSONCXX_ENUM
default : break;
Copy link
Contributor

@chardan chardan Sep 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: I think this is fine and will do what you want; consider also moving it ahead of the include-pasted cases, so that the latter will be indicated as an error instead of your more intentional case. (And, I think it's slightly easier to read, YYMV.)

}

_type = rhs._type;
Expand Down