Skip to content

Pass parameters from MaterialProcessor to TextureProcessor. - #4324

Merged
tomspilman merged 1 commit into
MonoGame:developfrom
nkast:MaterialToTextureProcessorParameters
Dec 17, 2015
Merged

Pass parameters from MaterialProcessor to TextureProcessor.#4324
tomspilman merged 1 commit into
MonoGame:developfrom
nkast:MaterialToTextureProcessorParameters

Conversation

@nkast

@nkast nkast commented Dec 16, 2015

Copy link
Copy Markdown
Contributor

"PremultiplyTextureAlpha" --> "PremultiplyAlpha"
"ResizeTexturesToPowerOfTwo" --> "ResizeToPowerOfTwo"

Thanks to @mgarstenauer for the fix.

"PremultiplyTextureAlpha" --> "PremultiplyAlpha"
"ResizeTexturesToPowerOfTwo" --> "ResizeToPowerOfTwo"
@nkast

nkast commented Dec 16, 2015

Copy link
Copy Markdown
Contributor Author

parametersred

@tomspilman

Copy link
Copy Markdown
Member

It would be really good to get a unit test for MaterialProcessor in place which could have caught this sooner. Sort of like i wrote for the TextureProcessor:

https://github.com/mono/MonoGame/blob/develop/Test/ContentPipeline/TextureProcessorTests.cs

Have any time @nkast ?

@tomspilman

Copy link
Copy Markdown
Member

Going to merge the fix for now... but unit tests really are needed.

tomspilman added a commit that referenced this pull request Dec 17, 2015
Pass parameters from MaterialProcessor to TextureProcessor.
@tomspilman
tomspilman merged commit efba55a into MonoGame:develop Dec 17, 2015
@nkast

nkast commented Dec 17, 2015

Copy link
Copy Markdown
Contributor Author

Ok, noted.

@tomspilman

Copy link
Copy Markdown
Member

Added an issue specific to that here: #4333.

@nkast
nkast deleted the MaterialToTextureProcessorParameters branch March 3, 2016 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants