Skip to content

[DSD-9230] image transfer from dev to dev2 - #1371

Merged
abhishek8shankar merged 3 commits into
mosip:release-1.2.0.1from
gaganamadival:release-1.2.0.1
Nov 13, 2025
Merged

[DSD-9230] image transfer from dev to dev2#1371
abhishek8shankar merged 3 commits into
mosip:release-1.2.0.1from
gaganamadival:release-1.2.0.1

Conversation

@gaganamadival

@gaganamadival gaganamadival commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated deployment image catalog: replaced a single 1.7.x image entry with a comprehensive set of components pinned to release-1.3.x (authentication, credential, identity, registration, kernel services, resident services, admin, artifactory, SDK/server components, and related platform services).

Signed-off-by: gaganamadival <94885434+gaganamadival@users.noreply.github.com>
Signed-off-by: gaganamadival <94885434+gaganamadival@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 13, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

Replaces the single image entry in release/vidivi/images.txt (previous mosipdev/apitest-esignet:release-1.7.x) with a large set of mosipdev image entries, each pinned to release-1.3.x. Change is data-only (image manifest list only).

Changes

Cohort / File(s) Summary
Image manifest updates
release/vidivi/images.txt
Removes the single mosipdev/apitest-esignet:release-1.7.x entry and adds 40+ mosipdev/* image entries (mock-abis, mock-mv, hotlist-service, admin-service, artifactory-server, biosdk-server, kernel-, data-share-service, digital-card-service, authentication-, credential-, id-repository-, pre-registration-, registration-processor-, resident-service, websub-service, consolidator-websub-service, and others), all set to release-1.3.x.

Sequence Diagram(s)

(The changes are a data-only update to an images manifest and do not alter control flow; no sequence diagram is provided.)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Check for duplicate or conflicting image lines in release/vidivi/images.txt
  • Verify all new entries use the release-1.3.x tag and correct image names
  • Confirm line formatting and ordering follow repository conventions

Possibly related PRs

Poem

🐰 I swapped one image for a whole parade,
Forty blossoms in a manifest glade.
Each tagged and tidy, all lined in a row,
A rabbit's small hop to a neatly-ordered show. 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'image transfer from dev to dev2' is vague and generic, using non-descriptive terms that don't clearly convey the specific nature of the changes (bulk addition of MOSIP component images to release-1.3.x). Revise the title to be more specific and descriptive of the actual changes, such as 'Add MOSIP 1.3.x component images to release manifest' or similar, to clearly indicate the bulk image additions.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f5515e and 6c0df1e.

📒 Files selected for processing (1)
  • release/vidivi/images.txt (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
release/vidivi/images.txt (1)

1-50: Verify version alignment and scope of this comprehensive service list replacement.

This change replaces 2 legacy image entries with 50 new services, all pinned to release-1.3.x. Two aspects require verification:

  1. Version Strategy: The PR targets branch release-1.2.0.1, but all images reference release-1.3.x. Confirm this is intentional (forward-looking transfer) and not a version mismatch.
  2. Scope & Accuracy: Verify that this comprehensive list of 50 services is complete, accurate, and all service names/identifiers are correct.

Consider adding a header comment to this file documenting its purpose and the version pinning strategy for future maintainability.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e4dd354 and 1f5515e.

📒 Files selected for processing (1)
  • release/vidivi/images.txt (1 hunks)

Signed-off-by: Abhishek S <127825992+abhishek8shankar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants