Skip to content

[DSD-9252]Moving images from dev to qa - #1408

Merged
ckm007 merged 1 commit into
mosip:release-1.2.0.1from
bhumi46:patch-6
Nov 22, 2025
Merged

[DSD-9252]Moving images from dev to qa#1408
ckm007 merged 1 commit into
mosip:release-1.2.0.1from
bhumi46:patch-6

Conversation

@bhumi46

@bhumi46 bhumi46 commented Nov 22, 2025

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Added multiple service components to release configuration for version 1.3.x, including registration processing, credential management, notification, landing zone, and identity repository services. All component versions align with the existing 1.3.x release to maintain consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: bhumi46 <111699703+bhumi46@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 22, 2025

Copy link
Copy Markdown

Walkthrough

Multiple image entries for various mosipdev services were added to the release/vidivi/images.txt configuration file, all targeting the release-1.3.x version. The additions include registration-processor subcomponents, credential services, id-repository services, and data-share service entries.

Changes

Cohort / File(s) Summary
Release Configuration Image Entries
release/vidivi/images.txt
Added 15 new mosipdev image entries for release-1.3.x: registration-processor common-camel-bridge, stage-groups 1-7, landing-zone, notification-service, dmz-packet-server, reprocessor, registration-status-service, registration-transaction-service, workflow-manager-service, credential-service, credential-request-generator, id-repository identity/vid services, and data-share-service.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Verify all 15 image entries follow the correct format and naming convention
  • Confirm each entry references the appropriate release-1.3.x version tag
  • Check for any duplicate entries or conflicts with existing configurations

Possibly related PRs

Suggested reviewers

  • ckm007

Poem

🐰 A carrot of configs, so tidy and neat,
Release-1.3.x makes the bundle complete!
Fifteen new images dance in the file,
Each service lined up with impeccable style.
The rabbit hops on, with a thumbs up so bright! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions moving images from dev to qa, but the actual changes add images to release-1.3.x version in release/vidivi/images.txt file, not moving them between environments. Revise the title to accurately reflect that images are being added to the release-1.3.x configuration, such as 'Add registration and credential service images to release-1.3.x' or 'Update release-1.3.x image entries for registration and credential services'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8e9b475 and 0ca853f.

📒 Files selected for processing (1)
  • release/vidivi/images.txt (1 hunks)
🔇 Additional comments (1)
release/vidivi/images.txt (1)

10-29: ****

The version mismatch concern is invalid. The images.txt file is a configuration for the vidivi Docker image transfer tool, which specifies which images to move from development to QA/production registries during the release process. The tags (e.g., release-1.3.x) refer to the release version being transferred, not the branch managing the configuration file.

The file already consistently uses release-1.3.x for 8 of 9 pre-existing entries. The 20 new entries follow this same established pattern with no duplicates, and the tool documentation confirms this is the correct behavior—images.txt specifies "the release version" to transfer independently of which branch manages the file.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ckm007
ckm007 merged commit 8ff695c into mosip:release-1.2.0.1 Nov 22, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants