Skip to content

[DSD-9452] mosipdev to mosipdev2 - #1459

Merged
abhishek8shankar merged 1 commit into
mosip:release-1.2.0.1from
SwapnilWorks-Devops:release-1.2.0.1
Dec 9, 2025
Merged

[DSD-9452] mosipdev to mosipdev2#1459
abhishek8shankar merged 1 commit into
mosip:release-1.2.0.1from
SwapnilWorks-Devops:release-1.2.0.1

Conversation

@SwapnilWorks-Devops

@SwapnilWorks-Devops SwapnilWorks-Devops commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated container images in the release configuration, replacing a single legacy image with an expanded set of multiple new images, all anchored to version 1.3.x for improved consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Swapnil <swapnil.mohanty@technoforte.co.in>
@coderabbitai

coderabbitai Bot commented Dec 9, 2025

Copy link
Copy Markdown

Walkthrough

The release/vidivi/images.txt configuration file is updated to replace a single mosipdev2-based image entry with a broader set of new mosipdev image entries. All new entries target the release-1.3.x version, expanding the set of managed container images from one to multiple entries.

Changes

Cohort / File(s) Summary
Image registry configuration
release/vidivi/images.txt
Replaced single mosipdev2/apitest-esignet:release-1.7.x entry with multiple mosipdev-based image entries, all targeting release-1.3.x

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

  • Verify the new image entries are correctly formatted and named
  • Confirm that all image versions and registry references (mosipdev namespace, release-1.3.x tags) are intentional

Possibly related PRs

Suggested reviewers

  • ckm007

Poem

🐰 Hoppity-hop, the images align,
From mosipdev2 to mosipdev's line,
Release-1.3.x shines brand new,
Multiple bundles, a wider view!
Configuration hops forward with glee, 🎉

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title 'mosipdev to mosipdev2' is misleading. The actual change replaces a single mosipdev2 image with multiple new mosipdev namespace images, not a conversion from mosipdev to mosipdev2. Revise the title to accurately reflect that multiple new mosipdev images are being added to replace an older mosipdev2 image, such as 'Update image entries from mosipdev2 to mosipdev namespace for release-1.3.x'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d5e7367 and 9be44e8.

📒 Files selected for processing (1)
  • release/vidivi/images.txt (1 hunks)
🔇 Additional comments (1)
release/vidivi/images.txt (1)

1-15: Verify PR title alignment and version strategy.

The PR title states "mosipdev to mosipdev2" but all 15 entries use the mosipdev namespace (not mosipdev2). Additionally, the previous entry (per the summary) targeted release-1.7.x, while all new entries target release-1.3.x—a version downgrade that requires justification.

Please clarify:

  1. Is the PR title accurate? Do these changes represent a revert from mosipdev2 back to mosipdev, or is the title incorrect?
  2. Is the version downgrade from 1.7.x to 1.3.x intentional? What is the business/operational rationale?
  3. Are all 15 service images required, or is this a net expansion of the manifest?

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@abhishek8shankar
abhishek8shankar merged commit f9b842e into mosip:release-1.2.0.1 Dec 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants