Skip to content

Cast of "max_velocity" and "max_acceleration" values to double#2803

Merged
henningkayser merged 2 commits intomoveit:mainfrom
JorgePRamos:joint_limits_change_to_double
Jun 14, 2024
Merged

Cast of "max_velocity" and "max_acceleration" values to double#2803
henningkayser merged 2 commits intomoveit:mainfrom
JorgePRamos:joint_limits_change_to_double

Conversation

@JorgePRamos
Copy link
Copy Markdown
Contributor

Description

Propose solution for open issue #2776 which tackles the generation of the joint_limits.yaml by the MoveIt setup assistant in which the generated values are Integers when Double are expected. A cast to double has been made as an attempt to solve this issue in s simple way.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 6, 2024

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Jun 6, 2024
@henningkayser henningkayser enabled auto-merge June 14, 2024 20:41
@henningkayser henningkayser added this pull request to the merge queue Jun 14, 2024
Merged via the queue into moveit:main with commit 5c11052 Jun 14, 2024
mikeferguson pushed a commit to mikeferguson/moveit2 that referenced this pull request Oct 23, 2024
…t#2803)

Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
sjahr pushed a commit that referenced this pull request Oct 25, 2024
#3038)

Co-authored-by: Jorge Pérez Ramos <jorgepramoscontact@gmail.com>
Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants