Cast of "max_velocity" and "max_acceleration" values to double#2803
Merged
henningkayser merged 2 commits intomoveit:mainfrom Jun 14, 2024
Merged
Cast of "max_velocity" and "max_acceleration" values to double#2803henningkayser merged 2 commits intomoveit:mainfrom
henningkayser merged 2 commits intomoveit:mainfrom
Conversation
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
henningkayser
approved these changes
Jun 14, 2024
mikeferguson
pushed a commit
to mikeferguson/moveit2
that referenced
this pull request
Oct 23, 2024
…t#2803) Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
This was referenced Oct 23, 2024
sjahr
pushed a commit
that referenced
this pull request
Oct 25, 2024
#3038) Co-authored-by: Jorge Pérez Ramos <jorgepramoscontact@gmail.com> Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propose solution for open issue #2776 which tackles the generation of the
joint_limits.yamlby the MoveIt setup assistant in which the generated values are Integers when Double are expected. A cast to double has been made as an attempt to solve this issue in s simple way.Checklist