Use ! in place of not keyword for Pilz and CHOMP planners (backport #3217)#3222
Merged
Conversation
* pilz_industrial_motion_planner: Use ! in place of not keyword for consistency * Use ! in place of not keyword for chomp_planner.cpp --------- Co-authored-by: JafarAbdi <jafar.uruc@gmail.com> (cherry picked from commit 549a2ee)
sea-bass
approved these changes
Jan 10, 2025
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## jazzy #3222 +/- ##
==========================================
- Coverage 44.19% 44.19% -0.00%
==========================================
Files 698 698
Lines 61586 61585 -1
Branches 7460 7459 -1
==========================================
- Hits 27214 27210 -4
- Misses 34205 34207 +2
- Partials 167 168 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While compiling this package on Windows (see RoboStack/ros-humble#241), the Windows compilation was failing as depending on the compilation options
notmay not be supported in MSVC depending on the compilation options.Anyhow, as everywhere else in the code
!is used, I think it make sense to be consistent and use!also here.Checklist
This is an automatic backport of pull request #3217 done by [Mergify](https://mergify.com).