Do not fail Rolling jobs on deprecations#3706
Merged
Conversation
Add new optional CI Rolling job that does fail on deprecations
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3706 +/- ##
==========================================
- Coverage 46.24% 0.00% -46.23%
==========================================
Files 726 539 -187
Lines 59483 47592 -11891
Branches 7624 6085 -1539
==========================================
- Hits 27504 0 -27504
- Misses 31813 47592 +15779
+ Partials 166 0 -166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stephanie-eng
approved these changes
Mar 16, 2026
Contributor
Author
|
Force merging this - the required Rolling jobs are failing due to lack of Qt6 support. The new optional rolling deprecated job is failing as expected due to deprecations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unfortunately, the timing+pace of rolling deprecations is outpacing the ability to address them with our current set of active maintainers and contributors. Originally we configured CI jobs to fail on deprecations to force us to fix them, but at this point, often when we go to fix them, there are several simultaneous deprecations from various upstream sources which requires one of the following to happen
This is not sustainable anymore (and promotes huge PRs that are tough to review), so what I'm doing in this PR is:
Depending on the state of upstream deprecations maintainers can change the state of this new, currently optional CI Rolling job that does fail on deprecations. But for now I would like to unblock community contributions while we address the current set of deprecations.
Checklist