typos corrected and support added for getting_started#587
typos corrected and support added for getting_started#587mlautman merged 2 commits intomoveit:melodic-develfrom
Conversation
…_started.rst, .build_locally.sh runs successfully now
|
Thanks for helping in improving MoveIt and open source robotics! |
There was a problem hiding this comment.
Thanks for the PR. I think rather than explaining the whole procedure (which takes up screen space and won't apply to many readers), supplying the right approach and search terms for those who might get stuck will be better. I won't block merging if others think it's helpful enough to go in, though.
| sudo apt install ros-melodic-moveit | ||
|
|
||
| Advanced users might want to `install MoveIt from source <http://moveit.ros.org/install/source/>`_. | ||
| If you clone your own moveit fork into the workspace, disable the moveit repository in the .rosinstall file. |
There was a problem hiding this comment.
| If you clone your own moveit fork into the workspace, disable the moveit repository in the .rosinstall file. | |
| If you want to build your own MoveIt fork, replace the repository uri in the .rosinstall file with your own. |
I think just this sentence will allow people to find the solution if they encounter issues. Explaining the procedure in detail doesn't really fit with the rest of the tutorial, so I would just leave it out.
| flattened_lines.extend( subs[sub_name] ) | ||
| else: | ||
| print 'tutorialformatter.py error: sub-tutorial %s not found.' % sub_name | ||
| print ('tutorialformatter.py error: sub-tutorial %s not found.' % sub_name) |
There was a problem hiding this comment.
| print ('tutorialformatter.py error: sub-tutorial %s not found.' % sub_name) | |
| print('tutorialformatter.py error: sub-tutorial " + sub_name + " not found.') |
Removes the space before the bracket and the C-style string formatting (which belongs on a dump imo).
Also remove the space before the bracket in the other line please
|
Congrats on getting your first MoveIt pull request merged and improving open source robotics! |
3 participants
Due to some typos in _scripts/tutorialformatter.py, ./build_locally.sh was not running, corrected them.
If any user wanted to build 'moveit' from source using his/her forked repository (for later contribution), it gets a little confusing as the 'build from source' tutorial mentions cloning (with wstool) using the ros_planning/moveit repos only. Support added for how he/she can clone the forked repository following the same lines as the provided tutorial (wstool) by changing few lines in the .rosinstall files.
Description
Please explain the changes you made, including a reference to the related issue if applicable
Checklist