bug 796871 - new app for gameon - #404
Conversation
There was a problem hiding this comment.
Check out mozorg.utils.page, it'll let you get rid of views.py completely.
|
I'll leave the rest of the review to @craigcook since he's a frontend master. |
|
Yes - I closed it by accident. Good news, I didn't press the merge pull request. Open now for any further reviews. |
There was a problem hiding this comment.
add aria-required="true" here to support browsers/AT that doesn't support just required :)
There was a problem hiding this comment.
Also No <label> element associated with the select element
|
Preferably this page should have a responsive layout unless there's a compelling reason for it not to. We're working to phase out all of the static width pages and all new pages on mozilla.org should use the responsive template. I can help guide you through making it responsive (just entails referencing some different template files and setting up the media queries). The banner image will be the only tricky part but it can probably just scale. |
|
@craigcook ah right, that isn't baked into the templates by default? Show me what ones to use and I'll drop stuff in there - as you say, easy enough to sort out :) |
|
@craigcook @icaaq thanks for looking over this - have updated the pull request fixing all the nits hopefully, and adding in the reponsive layout to boot! |
There was a problem hiding this comment.
No need for here, just an empty block will do.
There was a problem hiding this comment.
I'll try again - but in the past I've found I do need to put in the non-breaking space...
…y drop down box which is used on gameon, collusion and webmaker
bug 796871 - new app for gameon
4 participants
In addition noticed that the country select box we use for email sign-ups is now used in 3 different places, so removed duplication and create an external include file for this, and dropped it into a new app called 'foundation'