Skip to content

[Bug 1444044]Changed the Welcome Community Message #3247

Closed
turtlelovesshoes wants to merge 3 commits into
mozilla:masterfrom
turtlelovesshoes:master
Closed

[Bug 1444044]Changed the Welcome Community Message #3247
turtlelovesshoes wants to merge 3 commits into
mozilla:masterfrom
turtlelovesshoes:master

Conversation

@turtlelovesshoes

Copy link
Copy Markdown
Contributor

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1444044#c7
It looked like it should be pretty easy to update the text with updated information for this message that is triggered when a user signs up as a contributor then makes their first contribution.

+r

I added a new signature and removed the Buddy Program. I am keeping AOA there until changes are made to the UI to make Social Support more discoverable.
I removed the army of awesome link, added the kiwi link and removed the contributor quality training, the links are broken.
@vesper-mozilla

Copy link
Copy Markdown
Contributor

@pmac @jpetto Hey hey, what are the next steps to get this into Kitsune?

Cheers :)

@pmac

pmac commented Jul 11, 2018

Copy link
Copy Markdown
Contributor

Hi! Sorry for failing to get this in. I'll take a look today.

@pmac pmac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one typo and the changes need to be rebased on the current master branch before they'll merge cleanly. My apologies again for taking this long before reviewing this. Let me know when changes have been made and I'll make it a priority to merge and push these changes to production.

angry user does not want a work around or what happens next?
The Contributor Quality Training may have these answered. It
is possible to get started here:
Social Support Helper - Respond to tweets about Firefoxand as the Firefox brand account:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firefoxand needs a space I think.

@pmac

pmac commented Jul 11, 2018

Copy link
Copy Markdown
Contributor

I'm happy to fix that typo and do the rebase if you'd like. I did give it a try but resolving the conflicts wasn't as obvious as I'd hoped, so I thought perhaps you'd be better able to finalize the changes. But if you want or need help then I'm happy to do so.

@pmac

pmac commented Jul 13, 2018

Copy link
Copy Markdown
Contributor

I was able to do the rebase and have merged these changes into master in a3d0e6f. Let me know if you see any further issues. I can get this deployed to production today I think.

@pmac pmac closed this Jul 13, 2018
@pmac

pmac commented Jul 13, 2018

Copy link
Copy Markdown
Contributor

This is now in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants