Add build-time MT_DEBUG_DEFAULT support for Constants.DEBUG

[Copilot]

This change makes Constants.DEBUG configurable from the build environment instead of hardcoded false. Setting MT_DEBUG_DEFAULT=true during Gradle build now propagates into compiled code as the default debug value.

• Build-time debug config generation

  • Added a Gradle generateBuildConfig task that reads MT_DEBUG_DEFAULT (defaults to false) and generates org.mtransit.commons.BuildConfig.
  • Wired compileKotlin to depend on this task and include the generated sources directory.

• Runtime constant wiring

  • Updated Constants.DEBUG to read from BuildConfig.DEBUG_DEFAULT rather than a literal.

• Targeted test coverage

  • Added ConstantsTests to assert Constants.DEBUG matches the expected value derived from MT_DEBUG_DEFAULT (with false fallback when unset).

object Constants {
    @JvmStatic
    val DEBUG = BuildConfig.DEBUG_DEFAULT
}

[gemini-code-assist]

Code Review

This pull request introduces a mechanism to dynamically configure the Constants.DEBUG flag at build time using a generated BuildConfig class based on the MT_DEBUG_DEFAULT environment variable, and adds a unit test to verify this behavior. The review feedback suggests several improvements to the Gradle build configuration, including using providers.environmentVariable and declaring task inputs to support Gradle's Configuration Cache, registering the generated directory in Kotlin source sets for better IDE integration, and replacing the JVM assert keyword with assertEquals in tests to prevent assertions from being silently ignored.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[mmathieum]

@copilot address those #45 (comment) #45 (comment) #45 (comment)

[Copilot]

@copilot address those #45 (comment) #45 (comment) https://github.com/mtrans...

Addressed in commit 1176b2f.

• Switched MT_DEBUG_DEFAULT reading to providers.environmentVariable(...)
• Declared mtDebugDefault as an input to generateBuildConfig
• Registered generated source via kotlin.sourceSets.main.kotlin.srcDir(generateBuildConfig)
• Updated test assertion to assertEquals(...)

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a dynamic build configuration generation task in build.gradle to set the default debug flag based on the MT_DEBUG_DEFAULT environment variable, which is then used in Constants.kt. The review feedback suggests improving build reproducibility and reliability by cleaning the output directory before generation and explicitly specifying the UTF-8 charset when writing the generated file.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[mmathieum]

@copilot #45 (comment)

[Copilot]

@copilot #45 (comment)

Addressed in commit b816afa.

generateBuildConfig now deletes the generated output directory before writing and writes BuildConfig.kt using explicit UTF-8 encoding.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a Gradle task to dynamically generate a BuildConfig class containing a DEBUG_DEFAULT flag based on the MT_DEBUG_DEFAULT environment variable, and updates Constants.kt to utilize this generated value. The review feedback suggests replacing project.delete(outputDir) with outputDir.deleteDir() inside the task action to ensure compatibility with Gradle's configuration cache.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[mmathieum]

@copilot #45 (comment)