Validate withdrawal request body - #4761
Merged
Merged
Conversation
tomasmik
requested review from
Waldz,
mdomasevicius and
tadaskay
as code owners
February 9, 2022 11:50
tomasmik
force-pushed
the
validate-data
branch
2 times, most recently
from
February 9, 2022 11:52
df6afcd to
5e7b053
Compare
Guillembonet
approved these changes
Feb 9, 2022
Seems like people are able to somehow make withdrawal to a zero address. Logs from transactor: `json.beneficiary:0x0000000000000000000000000000000000000000`.
tomasmik
force-pushed
the
validate-data
branch
from
February 9, 2022 12:19
5e7b053 to
ea0b377
Compare
Snawoot
approved these changes
Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like people are able to somehow make withdrawal to a zero address, but their money is still deducted from the channel :)
Logs from transactor:
Updates: #4631