feat(codex): port multi-account Codex domain core (PR 1/5) - #255
Conversation
|
Thanks for the PR, I will review it ASAP. |
|
Thermo-nuclear series review (1/5 — domain) — direction-approved with two required items before merge. The porting itself reads correctly: Two items before this stack merges:
Non-blocking notes: the For the stack mechanics: merge strictly in order 255 → 256 → 258 → 259 → 260 and rebase each subsequent branch after every merge (squash merges rewrite ancestry). FYI the two earlier auto-close comments on PR 5/5 came from our former 4-PR-per-7d interaction limit — today's guard update (#263) raises it to 15, so |
Port the Windows multi-account Codex core from ademisler/codexcontrol (MIT) into rust/src/codex_accounts: account manager, quota API, Codex Desktop restart, versioned stores, and models. MIT attribution added to NOTICE.
9307345 to
d3a22c4
Compare
Summary
ademisler/codexcontrol(MIT) intorust/src/codex_accounts/(ADR 0003).NOTICE. No shell, UI, or behavior wiring yet; the ambient single-account Codex path is untouched.Related issue
ADR 0003 (
docs/adr/0003-multi-account-codex.md). No issue number yet.Affected areas
Validation
Hosted PR check runs on Blacksmith Windows when
CI_BUDGET_MODEis notoff(see.github/workflows/pr-check.ymlandCONTEXT.md). Still run the local slice and list commands/results below. If a check is not relevant, say why.powershell.exe -ExecutionPolicy Bypass -NoProfile -File scripts\local-check.ps1powershell.exe -ExecutionPolicy Bypass -NoProfile -File scripts\local-check.ps1 -All -Version <version>powershell.exe -File scripts\windows-release-build.ps1 -Ref <ref> -SmokeInstallUI / tray proof
For UI, tray, settings, or visual behavior changes, use CUA Driver for visual proof. If CUA Driver cannot be used, explain why and attach equivalent manual proof.
Notes for reviewers
ademisler/codexcontrolWindows core (per ADR 0003), not hand-written novel code; the vendor/migration diff does not split cleanly by file without breaking compilation. Review focus: diff against upstream semantics + the unit tests in-module.main.Chain Context
mainmainChain Overview
Scope
rust/src/codex_accounts/domain port,lib.rsmodule wiring,NOTICEattribution.Autonomy
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.