feat(codex): add Codex accounts panel in provider settings (PR 4/5) - #259
Conversation
|
Thanks for the PR, I will review this ASAP. |
|
Thermo-nuclear review (4/5 — settings panel): approve pending maintainer-run CUA proof. The section follows the existing settings-section grammar (Field/Toggle/form rows, i18n keys via Process: per repo AGENTS.md, settings-UI changes build CUA-driven proof after a fresh local rebuild — that's a maintainer-side artifact (contributors can't run our CUA). We'll take that on at merge time (same model as the notification-sounds PR in #251). Nothing blocked on you; landing both #255 items first applies. |
Render the ADR 0003 accounts panel inside the Codex provider detail pane: list accounts with usage bars, add/switch/fetch/remove actions, and the restart-desktop affordance, plus its dedicated styles.
58d1f1f to
468fa8c
Compare
Summary
Settings → Providers → Codex).CodexAccountsSectionlists accounts (ambient + managed) with per-account usage bars, and exposes add / switch / fetch / remove / restart-desktop actions wired to the bridge commands.styles.css(menu/tray styles land in PR 5/5) and mounts the section inProviderDetailPane.Related issue
ADR 0003 (
docs/adr/0003-multi-account-codex.md). No issue number yet.Affected areas
Validation
Hosted PR check runs on Blacksmith Windows when
CI_BUDGET_MODEis notoff(see.github/workflows/pr-check.ymlandCONTEXT.md). Still run the local slice and list commands/results below. If a check is not relevant, say why.powershell.exe -ExecutionPolicy Bypass -NoProfile -File scripts\local-check.ps1powershell.exe -ExecutionPolicy Bypass -NoProfile -File scripts\local-check.ps1 -All -Version <version>powershell.exe -File scripts\windows-release-build.ps1 -Ref <ref> -SmokeInstallpnpm test CodexAccountsSection(4 tests) passUI / tray proof
For UI, tray, settings, or visual behavior changes, use CUA Driver for visual proof. If CUA Driver cannot be used, explain why and attach equivalent manual proof.
Notes for reviewers
mainwill be rebased ontomainafter feat(codex): add frontend bridge types and i18n keys (PR 3/5) #258 merges.Chain Context
main(rebase after #258 merges)#258merged stateChain Overview
Scope
CodexAccountsSection.tsx(+ test), mount inProviderDetailPane.tsx, panel styles instyles.css.Autonomy
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.