feat(codex): add tray menu flyout for Codex accounts (PR 5/5) - #260
Conversation
|
This repository allows each user to open at most 4 pull requests per 7 days. Closing this automatically. |
|
This repository allows each user to open at most 4 pull requests per 7 days. Closing this automatically. |
|
Thanks for the PR, I will review this ASAP. |
|
Thermo-nuclear review (5/5 — tray flyout): approve pending maintainer-run CUA proof; guard situation already resolved.
Same CUA note as 4/5: we'll produce the tray-flyout proof after rebuilding locally post-merge. For merge order and the author-rebase-between-merges requirement, see the stacked-merge instructions on #255. |
Render an expandable Codex accounts flyout inside the tray menu card (option A): collapsed summary, per-account usage bars, and switch actions, using the shared bridge. Adds the flyout styles and MenuCard integration.
25fe257 to
8cc1332
Compare
) Follow-up CUA proof pass on #260 caught two defects: 1. Settings Codex-accounts card: a long account email paints over the 3-button actions row at the fixed 720px window and the 'No usage data' text wraps word-by-word. Pin the info column with min-width:0 + overflow/ellipsis/nowrap, cap the title at max-width:100% so it ellipsizes, and lock the actions row with flex-shrink:0 + nowrap. 2. Tray Codex accounts menu: an account whose snapshot only carries a weekly window (primaryWindow: null) rendered no usage bar. Fall back in canonical order (primary -> secondary; the account-snapshot bridge carries no tertiary/extra windows) so weekly-only accounts still render a bar. Tests: CodexAccountsMenu renders a 42% bar from a weekly-only snapshot; CodexAccountsSection asserts the containment CSS rules are present.
|
Follow-up CUA proof pass caught two polish defects found post-merge: (1) settings accounts card email overflow overlapping the actions row, (2) tray usage bar missing when an account snapshot has primaryWindow:null (weekly-only responses). Fixed in #264. |
Summary
CodexAccountsMenurenders an expandable<details>summary inside the Codex tray card.MenuCardmounts it forcodexprovider cards;maskEmailexported for reuse. Adds flyout styles tostyles.css.Related issue
ADR 0003 (
docs/adr/0003-multi-account-codex.md). No issue number yet.Affected areas
Validation
Hosted PR check runs on Blacksmith Windows when
CI_BUDGET_MODEis notoff(see.github/workflows/pr-check.ymlandCONTEXT.md). Still run the local slice and list commands/results below. If a check is not relevant, say why.powershell.exe -ExecutionPolicy Bypass -NoProfile -File scripts\local-check.ps1powershell.exe -ExecutionPolicy Bypass -NoProfile -File scripts\local-check.ps1 -All -Version <version>powershell.exe -File scripts\windows-release-build.ps1 -Ref <ref> -SmokeInstallpnpm test CodexAccountsMenu(3 tests) andpnpm run buildpassUI / tray proof
For UI, tray, settings, or visual behavior changes, use CUA Driver for visual proof. If CUA Driver cannot be used, explain why and attach equivalent manual proof.
Notes for reviewers
mainwill be rebased ontomainafter feat(codex): add Codex accounts panel in provider settings (PR 4/5) #259 merges.Chain Context
main(rebase after #259 merges)#259merged stateChain Overview
Scope
CodexAccountsMenu.tsx(+ test),MenuCard.tsxintegration, flyout styles instyles.css.Autonomy
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.