Update core snapshot to netft-cpp 0.3.1 - #5
Conversation
|
Warning Review limit reached
Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThe project now pins netft-cpp 0.3.1. FT stalls and backward-sequence discontinuities no longer deliver samples. Recovery tests and project documentation reflect the updated behavior. Changesnetft-cpp 0.3.1 update
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant FTRecordSource
participant HandleRecord as client_impl::handle_record
participant SampleConsumer
participant RecoveryPolicy
FTRecordSource->>HandleRecord: deliver FT records
HandleRecord->>RecoveryPolicy: evaluate stall or backward outcome
HandleRecord->>SampleConsumer: deliver only valid FT samples
HandleRecord->>RecoveryPolicy: clear matching outcome for reconnect recovery
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/integration/test_recovery.py (1)
156-164: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd a backward
ft_sequenceintegration test.Add a lower-
ft_sequencecase that expectsFaultCode.FT_BACKWARD,last_ft_progress == "backward", anddelivered_count == 1.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_recovery.py` around lines 156 - 164, Add a backward ft_sequence integration scenario alongside the existing recovery test, using the client sample flow to trigger a lower sequence value and asserting SensorFaultError with FaultCode.FT_BACKWARD. Verify the captured health reports last_ft_progress as "backward" and delivered_count as 1, while preserving the existing stall assertions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/integration/test_recovery.py`:
- Around line 156-164: Add a backward ft_sequence integration scenario alongside
the existing recovery test, using the client sample flow to trigger a lower
sequence value and asserting SensorFaultError with FaultCode.FT_BACKWARD. Verify
the captured health reports last_ft_progress as "backward" and delivered_count
as 1, while preserving the existing stall assertions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 268ccae5-b0c0-4668-bcae-e48f33a0f07c
📒 Files selected for processing (7)
CHANGELOG.mdREADME.mdcore/CMakeLists.txtcore/SNAPSHOT.sha256core/UPSTREAMcore/src/detail/client_impl.cpptests/integration/test_recovery.py
Updates the controlled native-core snapshot to netft-cpp v0.3.1 and aligns the fail-stop integration test with the upstream contract that FT-sequence discontinuity samples are not delivered.
Summary by CodeRabbit
Bug Fixes
Documentation