Skip to content

Conversation

@fmalmeida
Copy link
Contributor

@fmalmeida fmalmeida commented Mar 4, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/scrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

grst and others added 30 commits December 10, 2024 14:42
Fix problematic star index channel structure if params.star_index is provided
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok now for a release :-)

@DongzeHE
Copy link
Member

DongzeHE commented Mar 6, 2025

OK one last thing (I promise) before the release:

Compare with the current release, the simpleaf/quant module publishes mapping results in addition to quantification results. If save_reference=true, the simpleaf/index module publishes the augmented transcriptomic files in addition to the index folder.

My questions is, do we want to keep those extra files, or we want to align with the current release?

@fmalmeida fmalmeida mentioned this pull request Mar 6, 2025
@grst
Copy link
Member

grst commented Mar 6, 2025

Hi @DongzeHE, what do you mean with "mapping results"? Something like pseudo-BAM?

I don't think the save_reference flag is the appropriate argument for that, that's meant only for the reference. There's a save_align_intermeds flag though, that sounds better for your use-case.

@fmalmeida fmalmeida linked an issue Mar 6, 2025 that may be closed by this pull request
change publishing detail of simpleaf results
@grst grst changed the title v3.1.0 release v4.0.0 release Mar 10, 2025
@grst
Copy link
Member

grst commented Mar 10, 2025

@fmalmeida, bump version to 4.0 as discussed above and we are good to go? Or did I miss anything?

@fmalmeida
Copy link
Contributor Author

Hi @grst ,
That is correct. The other reviews have been resolved:
#446

@apeltzer
Copy link
Member

All fine for me too

@grst
Copy link
Member

grst commented Mar 10, 2025

ok, perfect!
@fmalmeida feel free to proceed with the release as described here: https://nf-co.re/docs/checklists/pipeline_release

@fmalmeida fmalmeida merged commit e0ddddb into master Mar 11, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add alevin alias for deprecation support of parameter