-
Notifications
You must be signed in to change notification settings - Fork 203
v4.0.0 release #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.0.0 release #439
Conversation
…ut---fb_reference-even-if-not-needed
Fix problematic star index channel structure if params.star_index is provided
Improve genome attribute handling
Dev fix ci simpleaf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ok now for a release :-)
|
OK one last thing (I promise) before the release: Compare with the current release, the simpleaf/quant module publishes mapping results in addition to quantification results. If My questions is, do we want to keep those extra files, or we want to align with the current release? |
|
Hi @DongzeHE, what do you mean with "mapping results"? Something like pseudo-BAM? I don't think the |
change publishing detail of simpleaf results
|
@fmalmeida, bump version to 4.0 as discussed above and we are good to go? Or did I miss anything? |
|
All fine for me too |
Bump version 4.0.0
|
ok, perfect! |
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).