Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can this editor merge cells in WYSWIG mode soon? #315

Closed
wants to merge 141 commits into from

Conversation

ikan88
Copy link

@ikan88 ikan88 commented Nov 2, 2018

Can this editor merge cells in WYSWIG mode soon?

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

It would be great if we can merge cells in WYSWIG mode.


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

kyuwoo.choi added 30 commits December 8, 2017 12:20
* refactor: split distribution for chart extension (fix #1021)

* refactor: split distibution for uml extension (fix #1021)

* refactor: split distribution for colorSyntax extension (fix#1021)

* refactor: split dist for scrollFollow extension (fix #1021)

* refactor: split dist for taskCounter extension (fix #1021)

* refactor: split dist for mark extension (fix #1021)

* refactor: split dist for table extension (fix #1021)

* refactor: change ext file path (fix #1021)

* refactor: global root to es6 import (fix #1021)

* refactor: change ext function name

* chore: extension namespace webpack config (#1021)

* refactor: static markdownit instance (fix #1021)

remove language option from chart, uml extensions

* chore: change namespace webpack config (fix #1021)

* chore: add script extension bundled build (fix #1021)

* fix: plantuml server encodng changed (fix: #1021)

* fix: apply code review (fix #1047)
Squashed commit of the following:

commit 9f179e4f0619999b740906abfbee1b8021339ca0
Author: kyuwoo.choi <kyuwoo.choi@nhnent.com>
Date:   Sat Dec 16 00:59:49 2017 +0900

    refactor: demo dep path to bower from npm (fix #1024)

commit b13129c10f387cc2382290df38c14cc8639c1192
Author: kyuwoo.choi <kyuwoo.choi@nhnent.com>
Date:   Fri Dec 15 22:14:09 2017 +0900

    style: eslint config

commit 88f1862fdfdcb68b5c7b83f1e6c662219d7a7fcb
Author: kyuwoo.choi <kyuwoo.choi@nhnent.com>
Date:   Fri Dec 15 21:27:54 2017 +0900

    refactor: namespace to es6 import (fix #1024)

commit 652aa682af8d0869d583f8714e8dc2012c0a58fb
Author: kyuwoo.choi <kyuwoo.choi@nhnent.com>
Date:   Fri Dec 15 16:04:46 2017 +0900

    refactor: update npm dep & es6 import for packages (fix #1024)

commit f9f3d46c67fd31f93539633d7c7b95866da2f719
Author: kyuwoo.choi <kyuwoo.choi@nhnent.com>
Date:   Fri Dec 15 11:12:23 2017 +0900

    refactor: npm dep update & es6 import jquery, colorpicker (fix #1024)

commit 6c05b7c208d363155d8133b83cae084d79233724
Author: kyuwoo.choi <kyuwoo.choi@nhnent.com>
Date:   Thu Dec 14 20:20:06 2017 +0900

    fix: broken wepack external conf for serve (fix #1021)

commit 1a4f92fb92dc5dc53f91cba508209eb77f5701d9
Author: kyuwoo.choi <kyuwoo.choi@nhnent.com>
Date:   Thu Dec 14 17:18:11 2017 +0900

    chore: update dependencies (fix #1024)
* docs: update readme for 1.0 (fix #1026)

* docs: apply review (fix #1055)
* test: remove src context from test bundle

* chore: prepare registration on npm, bower for 1.0 (fix #1022)

* chore: apply code review (fix #1022)
kyuwoo-choi and others added 24 commits June 15, 2018 17:37
* fix: wrong markdown list type change

* fix: wrong wysiwyg list type change

* refactor: apply code review (ref #209)
* feat: button enable/disable

* fix: wrong popup in markdown preview
* fix: image name breaks markdown syntax

* chore: update to-mark to 1.1.1

- it will help to fix escaping image name when converting from ww to md
* fix: deleting all table column breaks markdown

* refactor: apply code review (ref #216)
…#219)(#220)

- catch up to the latest continuelist markdown plugin.
  it also fixes increment numbers when item is added to the middle
- change codemirror command name newlineAndIndentContinue to newlineAndIndentContinueMarkdownList
- change codemirror command name subListIndentTab to indentOrderedList
#151, #155) (#207)

* fix: popup position in toolbar

* fix: make popups be children of the toolbar

* refactor: code style

* fix: colorpicker absolute position as a child of the toolbar
#222)

* fix: console error when creating a list with inline style

* refactor: apply code review (#222)
@kyuwoo-choi
Copy link
Member

you are in a wrong place @ikan88

please make an issue, not PR.

@kyuwoo-choi kyuwoo-choi closed this Nov 8, 2018
seonim-ryu pushed a commit that referenced this pull request Jan 2, 2020
@seonim-ryu seonim-ryu deleted the feat/toolbar_button_disable_status branch March 18, 2020 09:50
js87zz pushed a commit that referenced this pull request Jun 17, 2021
flipwordit pushed a commit to flipwordit/tui.editor that referenced this pull request Jan 7, 2022
Change build and serve process. It runs in vite
Add upgrade event in Editor.vue and Viewer.vue for handle content changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.