build: enable V8 gdb/lldb plugin support - #65786
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Build `v8_debug_helper.{so|dylib}` to enable V8 gdb/lldb postmortem
plugin support for the V8 version that Node.js built with.
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
legendecas
force-pushed
the
v8-debug-helper
branch
from
September 4, 2026 14:09
c54dab2 to
4fe78fe
Compare
richardlau
approved these changes
Sep 4, 2026
joyeecheung
approved these changes
Sep 4, 2026
Member
There was a problem hiding this comment.
LGTM. FWIW I had tested this commit joyeecheung@e280b0e a while back which disables it if the V8 is not bundled (in which case we don't know if it's compatible). I plan to add some version matching mechanism similar to Windbg to ensure that there is some compatibility check. IIRC as early as 15.3 we already had a "ABI" breaking change.
legendecas
added
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
benjamingr
approved these changes
Sep 4, 2026
jasnell
approved these changes
Sep 4, 2026
panva
added
the
commit-queue
Collaborator
|
Landed in 718cfe4 |
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Sep 7, 2026
Build `v8_debug_helper.{so|dylib}` to enable V8 gdb/lldb postmortem
plugin support for the V8 version that Node.js built with.
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #65786
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 7, 2026
Build `v8_debug_helper.{so|dylib}` to enable V8 gdb/lldb postmortem
plugin support for the V8 version that Node.js built with.
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #65786
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build
libv8_debug_helper.{so|dylib}to enable V8 gdb/lldb postmortemplugin support for the V8 version that Node.js built with.
The built debug helper library can be loaded with this V8 gdb/lldb
https://chromium.googlesource.com/v8/v8.git/+/refs/heads/main/tools/debug_helper/plugins/
plugin.