EdgeHTML-based Edge: do not treat address omnibar as a search field#10200
Merged
michaelDCurran merged 1 commit intoSep 13, 2019
Merged
Conversation
…onger a search field. Re nvaccess#10002. Thanks to UIA auto-select for eit fields, it is no longer necessary to treat Edge's address omnibar as a dedicated search field, in that search results will be announced automatically. This also resolves an issue where NVDA kept playing search suggestion sound when Edge was maximized due to odd controller for event being fired by omnibar itself.
Collaborator
|
Will this still announce suggestions on the address bar? Honestly, it's not clear to me whether this pr would introduce any disadvantages to the user. |
Contributor
Author
|
Hi, yes thanks to UIA auto-select. Thanks.
From: Leonard de Ruijter <notifications@github.com>
Sent: Wednesday, September 11, 2019 10:21 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author <author@noreply.github.com>
Subject: Re: [nvaccess/nvda] EdgeHTML-based Edge: do not treat address omnibar as a search field (#10200)
Will this still announce suggestions on the address bar? Honestly, it's not clear to me whether this pr would introduce any disadvantages to the user.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#10200?email_source=notifications&email_token=AB4AXEFJYFA7CCFEL35H7T3QJHGSBA5CNFSM4IVXHXE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6QV3ZY#issuecomment-530669031> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AB4AXEEHEPLFMENL457IQ6TQJHGSBANCNFSM4IVXHXEQ> .
|
michaelDCurran
approved these changes
Sep 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10002
Fixes #9110
Summary of the issue:
Classic (EdgeHTML-based) Edge's address omnibar is treated as a search field, causing it to fire controller for event when Edge window is maximized.
Description of how this pull request fixes the issue:
Removes Edge's address omnibar from being treated as a search field.
Testing performed:
Tested with Windows 10 App Essentials add-on for several months.
Known issues with pull request:
None
Change log entry:
Bug fixes:
In Microsoft Edge based on EdgeHTML, NVDA will no longer play search suggestion sound when the window becomes maximized. (#9110, #10002)
Thanks.