appModules/SearchUI: add support for announcing suggestion count in Windows 10 Version 1909 and later by josephsl · Pull Request #10349 · nvaccess/nvda

josephsl · 2019-10-08T06:24:43Z

Link to issue number:

Summary of the issue:

In Windows 10 Version 1909, File Explorer gains ability to search OneDrive content via Windows Search, with a live region used to provide suggestion count announcement.

Description of how this pull request fixes the issue:

In Windows 10 Version 1909 (build 18363) and later, File Explorer gains ability to search OneDrive content. This is powered by an embedded Windows Search feature (SearchUI.exe) with a live region announcing suggestion count. This live region has no label, but the child object does, thus coerce the name of this object to be the name of its child, which then allows live region change event to work.

Testing performed:

Tested in Version 1909 (build 18363) and via Windows 10 App Essentials add-on.

Known issues with pull request:

None

Change log entry:

Possibly either new features or changes:

In Windows 10 Version 1909 (change this wording to marketing name once 1909 comes out), NVDA will announce suggestion count when performing searches in File Explorer. (#10231

LeonarddeR · 2019-10-23T08:09:02Z

Is this somehow related to #8472?

josephsl · 2019-10-23T13:18:02Z

Hi, I can see a connection – let me test that PR to see if this one can be rephrased as such. Thanks.

josephsl · 2019-10-23T13:23:19Z

Hi, this is different than #8466, as there is no “alert” associated with this one. Thanks.

josephsl · 2019-12-17T03:39:42Z

Hi,

It is ready for another round of review after 2019.3 is released. Thanks.

josephsl · 2020-02-16T10:26:04Z

Hi,

Indeed, 2019.3 was released.

Thanks.

…indows 10 Version 1909. Re nvaccess#10341. In Windows 10 Version 1909 (build 18363) and later, File Explorer gains ability to search OneDrive content. This is powered by an embedded Windows Search feature (SearchUI.exe) with a live region announcing suggestion count. This live region has no label, but the child object does, thus coerce the name of this object to be the name of its child, which then allows live region change event to work.

josephsl · 2020-05-06T05:54:35Z

Hi,

Update: I haven't forgotten about this PR - it's just that more important pull requests came along and developers are going through backlog.

Thanks.

…ss#10341.

AppVeyorBot · 2021-03-15T18:41:11Z

System test failure
Build (for testing PR)

See test results for failed build of commit f3a275b085

AppVeyorBot · 2021-04-05T13:08:54Z

System test failure
Build (for testing PR)

See test results for failed build of commit 727743f2b0

codeofdusk · 2021-05-14T05:06:56Z

Any updates on this PR?

josephsl · 2021-05-14T05:11:47Z

Hi, I might resurrect this for 2021.2 – see a discussion between I and @jcsteh for some thoughts about this. In fact, I just committed changes to Windows 10 App Essentials that might help with this PR. Note that announcing suggestion count applies to apps other than SearchUI/SearchApp (Windows Search) because these apps do report suggestion count (navigator object moves to suggestions list which does report position info). Thanks.

josephsl · 2021-05-14T05:16:51Z

Hi,
Never mind about the above comment, as I thought it was #7330. The PR is indeed ready to go - I'd wait for 2021.2 cycle begins before requesting another formal review.

Thanks.

feerrenrut · 2021-05-19T10:07:31Z


+	def event_NVDAObject_init(self, obj):
+		if isinstance(obj, UIA):
+			# #10341: Build 18363 introduces modern search experience in File Explorer.


If this is only available in Build 18363 and later, should this be protected by a check for the windows version? If not, please describe in the comment how this code handles earlier versions. I assume that the UIAAutomationId wont be suggestionCountForNarrator in earlier builds of Windows?

feerrenrut · 2021-05-19T10:08:00Z

 				pass
 		elif isinstance(obj, UIA):
-			if obj.UIAElement.cachedAutomationID == "SearchTextBox":
+			if obj.UIAAutomationId == "SearchTextBox":


Perhaps this is only ever true in post 18363 builds?

Can you verify whether this change is applicable to earlier builds? It may need the same windows version check.

josephsl · 2021-05-19T18:02:52Z

Hi, modern search integration was introduced in 18363, and prior to that, the search UI is different (I’ll add a check for windows releases just to make sure).

feerrenrut · 2021-05-20T09:26:44Z

Ok. But the problem I want to solve is:
"From the perspective of a code reader, how do they know that this code will only run on the intended versions of windows?"

josephsl · 2021-05-20T09:29:54Z

Hi, one simple solution I think (which I will do before I sleep) is specifying on which Windows 10 version the code will run on (winVersion.WIN10_1909, to be exact). Thanks.

…ble from Windows 10 Version 1909 (build 18363/NOvember 2019 Update). Re nvaccess#10341. Comment from Reef Turner (NV Access): clarify that Windows Search/suggestion count in File Explorer is available from Windows 10 Version 1909, also split the condition into multiple lines to prepare for Flake8 (lint).

josephsl · 2021-05-20T10:29:08Z

Hi, no need to change this, as SearchUI was introduced in Windows 10, although I think a header comment should clarify this fact (@michaelDCurran had an adventure with this app module in particular back in 2015 because Windows Search kept freezing for some odd reason). Thanks,

josephsl · 2021-07-06T02:01:22Z

Hi,

A component of #12585 because searchapp.exe was renamed to searchhost.exe in Windows 11, complete with exact same live region implementation as this PR. Therefore, once this PR is erviewed and merged, it can be applied easily to Windows 11 by introducing an alias app module for searchhost.exe that will import from searchui.py.

Thanks.

lukaszgo1 · 2021-07-06T10:59:03Z

@feerrenrut It looks like all changes that you've requested has been addressed. Would it be possible to re-review this?

…n1909

feerrenrut · 2021-07-08T05:47:49Z

How to test:

Open explorer window Windows + e
Press F3 to focus search
Type something. Note "10 suggestions available, press down arrow key to access results" announced, this is new.
Press down arrow, file name and details should be announced

feerrenrut

Thanks @josephsl

josephsl requested a review from michaelDCurran October 8, 2019 06:24

josephsl force-pushed the i10341searchuiWinTen1909 branch from ddbcfcb to 2021633 Compare February 16, 2020 10:27

feerrenrut added enhancement app/windows-interface Interactions between NVDA and the default Windows GUI labels Apr 8, 2020

dpy013 mentioned this pull request Apr 23, 2020

Touch interaction: allow users to disable touch support completely #10557

Merged

josephsl changed the title ~~appModules/SearchUI: add support for announcing suggestion count in Windows 10 Version 1909~~ appModules/SearchUI: add support for announcing suggestion count in Windows 10 Version 1909 and later Jun 17, 2020

josephsl added 4 commits August 9, 2020 20:41

Merge branch 'master' into i10341searchuiWinTen1909

727c634

appModules/searchUI: update copyright year.

5a1ec50

appModules/searchUI: cachedAutomationID -> UIAAutomationId. Re nvacce…

71824e0

…ss#10341.

Merge branch 'master' into i10341searchuiWinTen1909

26d03c1

josephsl added 2 commits April 5, 2021 05:50

Merge branch 'master' into i10341searchuiWinTen1909

5895ebd

appModules/SearchUI: update copyright year

5b87452

Merge branch 'master' into i10341searchuiWinTen1909

6c404f2

josephsl requested a review from a team as a code owner May 14, 2021 05:20

feerrenrut reviewed May 19, 2021

View reviewed changes

josephsl added 2 commits May 20, 2021 02:31

Merge branch 'master' into i10341searchuiWinTen1909

ad4f44b

Merge remote-tracking branch 'origin/master' into i10341searchuiWinTe…

418697b

…n1909

feerrenrut self-requested a review July 8, 2021 05:28

Update changes file for PR nvaccess#10349

fc002fd

feerrenrut approved these changes Jul 8, 2021

View reviewed changes

feerrenrut merged commit d304ed0 into nvaccess:master Jul 8, 2021

nvaccessAuto added this to the 2021.2 milestone Jul 8, 2021

josephsl deleted the i10341searchuiWinTen1909 branch July 9, 2021 04:12

Uh oh!

Conversation

josephsl commented Oct 8, 2019

Link to issue number:

Summary of the issue:

Description of how this pull request fixes the issue:

Testing performed:

Known issues with pull request:

Change log entry:

Uh oh!

LeonarddeR commented Oct 23, 2019

Uh oh!

josephsl commented Oct 23, 2019 via email • edited by feerrenrut Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

josephsl commented Oct 23, 2019 via email • edited by feerrenrut Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

josephsl commented Dec 17, 2019

Uh oh!

josephsl commented Feb 16, 2020

Uh oh!

josephsl commented May 6, 2020

Uh oh!

AppVeyorBot commented Mar 15, 2021

Uh oh!

AppVeyorBot commented Apr 5, 2021

Uh oh!

codeofdusk commented May 14, 2021

Uh oh!

josephsl commented May 14, 2021 via email

Uh oh!

josephsl commented May 14, 2021

Uh oh!

feerrenrut May 19, 2021

Choose a reason for hiding this comment

Uh oh!

feerrenrut May 19, 2021

Choose a reason for hiding this comment

Uh oh!

feerrenrut May 20, 2021

Choose a reason for hiding this comment

Uh oh!

josephsl commented May 19, 2021 via email • edited by feerrenrut Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

feerrenrut commented May 20, 2021

Uh oh!

josephsl commented May 20, 2021 via email

Uh oh!

josephsl commented May 20, 2021 via email

Uh oh!

josephsl commented Jul 6, 2021

Uh oh!

lukaszgo1 commented Jul 6, 2021

Uh oh!

feerrenrut commented Jul 8, 2021

Uh oh!

feerrenrut left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

josephsl commented Oct 23, 2019 via email •

edited by feerrenrut

Loading

josephsl commented Oct 23, 2019 via email •

edited by feerrenrut

Loading

josephsl commented May 19, 2021 via email •

edited by feerrenrut

Loading