Skip to content

Use QuickNav Reason - #12939

Merged
feerrenrut merged 3 commits into
masterfrom
useQuickNavReason
Oct 21, 2021
Merged

Use QuickNav Reason#12939
feerrenrut merged 3 commits into
masterfrom
useQuickNavReason

Conversation

@feerrenrut

@feerrenrut feerrenrut commented Oct 15, 2021

Copy link
Copy Markdown
Contributor

Link to issue number:

Related to PR #12933

Summary of the issue:

When quick nav commands are used, the reason given to speakTextInfo is FOCUS.
This makes it impossible to treat quick nav and focus changed differently.

Description of how this pull request fixes the issue:

OutputReason.QUICKNAV was generally not used, not at all in the chain of calls resulting from speech.speakTextInfo
Treat QUICKNAV in the same way as FOCUS so that they can be differentiated in the future.

Testing strategy:

Merge early in dev cycle, and rely on alpha testing.

Known issues with pull request:

It may be intentional to enforce treating quick nav and focus changed in the same way.

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

OutputReason.QUICKNAV was generally not used, not at all in the chain of
calls resulting from speech.speakTextInfo

Treat QUICKNAV in the same way as FOCUS so that they can be
differentiated in the future.
@feerrenrut feerrenrut added the audience/nvda-dev PR or issue is relevant to NVDA / Add-on developers label Oct 15, 2021
@feerrenrut feerrenrut added this to the 2022.1 milestone Oct 15, 2021
@feerrenrut
feerrenrut marked this pull request as ready for review October 15, 2021 09:00
@feerrenrut
feerrenrut requested a review from a team as a code owner October 15, 2021 09:00
@feerrenrut
feerrenrut merged commit 5114ccc into master Oct 21, 2021
@feerrenrut
feerrenrut deleted the useQuickNavReason branch October 21, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audience/nvda-dev PR or issue is relevant to NVDA / Add-on developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants