Use QuickNav Reason - #12939
Merged
Merged
Conversation
OutputReason.QUICKNAV was generally not used, not at all in the chain of calls resulting from speech.speakTextInfo Treat QUICKNAV in the same way as FOCUS so that they can be differentiated in the future.
feerrenrut
marked this pull request as ready for review
October 15, 2021 09:00
michaelDCurran
approved these changes
Oct 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Related to PR #12933
Summary of the issue:
When quick nav commands are used, the
reasongiven tospeakTextInfoisFOCUS.This makes it impossible to treat quick nav and focus changed differently.
Description of how this pull request fixes the issue:
OutputReason.QUICKNAVwas generally not used, not at all in the chain of calls resulting fromspeech.speakTextInfoTreat
QUICKNAVin the same way asFOCUSso that they can be differentiated in the future.Testing strategy:
Merge early in dev cycle, and rely on alpha testing.
Known issues with pull request:
It may be intentional to enforce treating quick nav and focus changed in the same way.
Change log entries:
None
Code Review Checklist: