App modules/SearchUI: announce search result details with the 2019 UI redesign applied#13620
Merged
seanbudd merged 6 commits intonvaccess:masterfrom Apr 26, 2022
Merged
Conversation
…m. Re nvaccess#13544. Windows Search user interface has changed in 2019, causing NVDA to not announce search result details. This is because suggestion list items are now grandchildren of the results list, not its children. Therefore also check grandparent object when detecting suggestion list items, allowing NVDA to announce result details on Windows 10 and 11.
…app modules exist to handle later Windows releases. Alias app modules fos SearchUI app module: * searchapp: Windows 10 Version 2004 and later * searchhost: Windows 11 Although alias app modules do have intro comments, add a comment to the base app module as well.
See test results for failed build of commit a4b3ba4c1a |
seanbudd
reviewed
Apr 22, 2022
| elif ( | ||
| obj.role == controlTypes.Role.LISTITEM and ( | ||
| isinstance(obj.parent, SuggestionListItem) | ||
| or isinstance(obj.parent.parent, SuggestionListItem) |
Member
There was a problem hiding this comment.
Is this a safe getattr? Can obj.parent be None?
Contributor
Author
|
Hi, yes, it is a safe getattr as search results are housed inside a “Bing” document. Thanks
|
seanbudd
approved these changes
Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #13544
Summary of the issue:
In 2019, Start menu/Windows Search UI has changed, causing NVDA to not announce search result details. This was traced to search result items being grandchildren of the results list.
Description of how this pull request fixes the issue:
In addition to lint and documentation update, check the instance of the obj.parent.parent (grandparent) to make sure it is results list so NVDA can announce search result details. This is applicable to Windows 10 and 11.
Testing strategy:
Manual testing:
Known issues with pull request:
None
Change log entries:
Bug fixes:
NVDA will once again announce Start menu search result details in recent Windows 10 and 11 releases. (#13544)
Code Review Checklist: