Fix SAPI5 - #18802
Merged
Merged
Conversation
gexgd0419
marked this pull request as ready for review
August 26, 2025 03:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18797.
Summary of the issue:
NVDA is silent after executing certain gestures.
Description of user facing changes:
The problem mentioned above should be fixed.
Description of developer facing changes:
None.
Description of development approach:
Reset the
_isCancelledflag to False before speaking. Otherwise, calling cancel before speak may silence the later speak.Testing strategy:
Tested manually.
Known issues with pull request:
None.
Code Review Checklist: