Symbols and character descriptions for Luxembourgish

[zstanecic]

Link to issue number:

Not applicable

Summary of the issue:

Not applicable

Description of user facing changes:

Users will hear punctuation and symbols in the Luxembourgish language with the supported tts.

Description of developer facing changes:

Not applicable

Description of development approach:

Created the symbols file and character descriptions for lexembourgish

Testing strategy:

Tested locally that it works.

Known issues with pull request:

None

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

[Copilot]

Pull Request Overview

This pull request adds Luxembourgish language support to NVDA by introducing symbols and character description files for the lb locale. This enables Luxembourgish-speaking users to hear punctuation, symbols, and character descriptions in their language when using NVDA with supported text-to-speech engines.

Key changes:

• Created source/locale/lb/symbols.dic with 347 symbol definitions including punctuation, mathematical symbols, and special characters
• Created source/locale/lb/characterDescriptions.dic with phonetic alphabet descriptions adapted for Luxembourgish pronunciation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 12 comments.

File	Description
source/locale/lb/symbols.dic	New symbols dictionary file defining how NVDA pronounces punctuation, mathematical operators, currency symbols, fractions, and other special characters in Luxembourgish
source/locale/lb/characterDescriptions.dic	New character descriptions file providing phonetic alphabet descriptions (NATO alphabet adapted to Luxembourgish pronunciation) for spelling out characters

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[zstanecic]

This is ready for review and eventual merging. One note
When somebody merges this, Please update the Cldr to v48, and add the lb data, please.

[seanbudd]

@zstanecic - are any of the copilot review comments accurate?

[zstanecic]

Hi @seanbudd
I don't take copilot comments into account. This was checked with the native speakers. There were no complaints from them.

[seanbudd]

@zstanecic - While I appreciate your rejection from AI, CoPilot is going to be better at reviewing this than NV Access. Can you please read through them and mark them as resolved if they are irrelevant?

[zstanecic]

Done.

[seanbudd]

Thanks, and appreciate you getting the docs reviewed by the community as well. I was curious on the quality of the review as I was surprised CoPilot would even provide suggestions like this, I'm guessing it was bad?

[CyrilleB79]

I do not speak Luxembourgish but with German knowledge and a bit of logic, it's quite obvious that most of Copilot comments were valid. I have not gone through all but have provided answer to 3 of them.

@zstanecic it seems that you have just closed / ignored Copilot comments without double-checking, despite @seanbudd's recommendations, and that your contact in the Luxembourgish community has not performed an in-depth review of the file!

Can you please at least go through all Copilot's comments and provide the needed fixes in another PR?

[zstanecic]

With all respect to you and @seanbudd, but I don't believe the Ai there.
The problem is that community didn't make any objections.
When Sean merges the pull request with the latest improvements regarding hyphen, i will check this. The intention was to give this to broader testing.

[zstanecic]

By the way, this was merged, and if any fixes needs to be made, I will rather open a new pr, and not discussing it in the old one.