Symbol files alignment with english, and further fixes to luxembourgish#19256
Symbol files alignment with english, and further fixes to luxembourgish#19256seanbudd merged 5 commits intonvaccess:masterfrom
Conversation
…file updates. reason: aligning with the english file by adding hyphen.
There was a problem hiding this comment.
Pull Request Overview
This PR aligns symbol dictionary files across multiple locales (Slovak, Polish, Luxembourgish, Croatian, Czech, and Belarusian) with the English version by adding the hyphen character (U+2010 ‐).
- Adds the hyphen symbol entry with appropriate translations in 6 locale files
- Updates line numbering in the Czech locale file to maintain consistency
- Corrects line numbering in the Belarusian locale file
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| source/locale/sk/symbols.dic | Adds hyphen entry at line 113 with Slovak translation "spojovník" |
| source/locale/pl/symbols.dic | Adds hyphen entry at line 100 with Polish translation "dyviz" |
| source/locale/lb/symbols.dic | Adds hyphen entry at line 101 with Luxembourgish translation "digital Bindestrëch" |
| source/locale/hr/symbols.dic | Adds hyphen entry at line 100 with Croatian translation "spojnica" |
| source/locale/cs/symbols.dic | Adds hyphen entry at line 68 and fixes line numbering |
| source/locale/be/symbols.dic | Adds hyphen entry at line 124 with "always" preserve parameter and fixes line numbering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi, just to confirm, do you speak all of these languages? Or have you checked with the translators. Either way, thank you |
|
I checked the official translation for the symbols. I am myself maintaining polish and croatian, and I confirm the czech and slovak translation as official for the respective languages. |
|
Also, the luxembourgish is aligned, too. |
|
So, all is checked with the respective sources, plus I am maintaining polish, Czech and belarusian. |
|
So, |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Added review fixes for luxembourgish from #19241 |
|
@CyrilleB79 now it should be okay. |
zstanecic
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
source/locale/lb/symbols.dic
Outdated
| … sentence ending Ellips all always | ||
| Datumstrennzeichen Punkt none norep | ||
| Dezimaltrennzeichen none always | ||
| Tausendertrennzeichen |
There was a problem hiding this comment.
This line appears to be incomplete. It's missing the level and preserve values after the replacement text. Based on line 41 and the pattern in other symbol files, this should likely be:
Tausendertrennzeichen none always
or have an appropriate replacement text and parameters.
| Tausendertrennzeichen | |
| Tausendertrennzeichen none always |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
bThis is hopefully ready. |
|
I hereby confirm, that my changes are right, along with applied majority of comments by @CyrilleB79 |
There was a problem hiding this comment.
In this file, we have:
- sometimes "Superscript" and sometimes "uewen"
- sometimes "Ënnerschrëft" and sometimes "Subskript"
Is this expected?
I do not speak this language, so I'm just asking to confirm all is OK, not requesting a change.
|
Yes, this is Ok. In the future, when I get more review from the users itself, I will add eventual fixes, but for now it is all Ok. |
Co-authored-by: Cyrille Bougot <cyrille.bougot2@laposte.net>
|
Applied the last review suggestion. Thanks! |
|
I will ask copilot for another review. If this passes. It means this is ready fully. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Okay. To conclude, the fixes are fully ready, as well as the english file alignment. |
CyrilleB79
left a comment
CyrilleB79
left a comment
There was a problem hiding this comment.
I have had a quick look at the changes of the Luxembourgish file and nothing seems strange to me.
Though, keep in mind that:
- I don't speak Luxembourgish at all
- I have only looked at what the AI had mentioned in the previous PR, that's not a full review of this file (or even all the changes)
|
@CyrilleB79 but all your comments made a perfect sense, so thank you for this, so all is Ok. |
…file updates.
reason: aligning with the english file by adding hyphen.
Link to issue number:
Not applicable
Summary of the issue:
Updates the symbol files to align it with English latest changes
Description of user facing changes:
Adds hyphtn with the corresponding fixes.
Description of developer facing changes:
Not applicable
Description of development approach:
Added the hyphen from the english file to be transferred to the speech synthesizer.
Testing strategy:
Tested in the source copy.
Known issues with pull request:
None known
Code Review Checklist: