Conversation
Update translations from beta
Resolves #19114 Summary of the issue: NVDA reads the Unicode hyphen (U+2010) differently from the standard ASCII hyphen-minus (U+002D). When U+2010 appears inside compound words like "open‑source", NVDA would read it explicitly as “open hyphen source” which is incorrect. Description of user facing changes: Compound words containing U+2010 are now read naturally without calling out “hyphen.” Description of developer facing changes: Added the following line to source/locale/en/symbols.dic under Standard punctuation/symbols: hyphen most always This ensures U+2010 is preserved inside words but not spoken explicitly. Description of development approach: U+2010 (Unicode hyphen) previously had level=0 and preserve=0, causing it to be read aloud as “hyphen” inside words. By adding an entry in source/locale/en/symbols.dic: This sets an appropriate level and preserve value so that U+2010 is preserved in compound words but not explicitly spoken.
Summary of the issue: Updated to actions/checkout-v6 Description of user facing changes: none Description of developer facing changes: Updated testAndPublish.yml files Description of development approach: Updated: uses: actions/checkout@v6
…sh (#19256) Link to issue number: Not applicable Summary of the issue: Updates the symbol files to align it with English latest changes Description of user facing changes: Adds hyphen with the corresponding fixes. Description of developer facing changes: Not applicable Description of development approach: Added the hyphen from the english file to be transferred to the speech synthesizer.
#19003 follow up ### Summary of the issue: This pull request makes a minor update to the licensing information in the project documentation. The change clarifies that NVDA is available under a modified GNU General Public License version 2 or any later version. Updated the license statement in `readme.md` to specify "version 2 or later" rather than just "version 2" for the GNU General Public License.
### Summary of the issue: This pull request adds new documentation to help Crowdin administrators manage translations for NVDA. The main focus is on providing clear instructions for adding languages, translation files, and translators. Added a new section in `projectDocs/translating/admin.md` with step-by-step instructions for adding new languages via Crowdin settings and integrating them into NVDA.
Summary of the issue: Fetching translations from Crowdin is failing because pre-commit is failing to install on the github actions image. This is because pyright is failing to install. We rely on pre-commit to ensure translated files don't introduce regressions. https://github.com/nvaccess/nvda/actions/runs/19559152241 Description of user facing changes: none Description of developer facing changes: run pyright with uv directly when using pre-commit. This might result in slightly different output to the official hook. This has the following benefits: we don't need to manually sync versions it matches closer to what we run in GitHub CI (ci/scripts/tests/typeCheck.ps1), as pre-commit CI doesn't support pyright anyway Description of development approach: See above
Contributor
There was a problem hiding this comment.
Pull request overview
This PR merges updates from the master branch to beta, including localization improvements, dependency updates, and new documentation.
- Addition of hyphen symbol (‐) across multiple locale symbol dictionaries
- Corrections to typos and mistranslations in Polish and Luxembourgish locale files
- Migration of pyright type checking from separate repo to local uv-managed hook
- Update to GitHub Actions checkout version
- License clarification in readme
- New Crowdin administration documentation
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| source/locale/sk/symbols.dic | Added hyphen symbol (‐) entry with line number 113 |
| source/locale/pl/symbols.dic | Corrected typo "piewszej" to "pierwszej" and added hyphen symbol with proper line numbering |
| source/locale/lb/symbols.dic | Added missing line numbers, corrected mistranslations from German to Luxembourgish for fractions and bracket symbols, added hyphen and decimal/thousand separator entries |
| source/locale/hr/symbols.dic | Added hyphen symbol (‐) entry with line number 100 |
| source/locale/en/symbols.dic | Added hyphen symbol (‐) entry with line number 99 |
| source/locale/cs/symbols.dic | Added hyphen symbol (‐) entry with line number 68 |
| source/locale/be/symbols.dic | Updated hyphen symbol entry to include "always" preserve flag on line 124 |
| readme.md | Clarified license as "version 2 or later" instead of just "version 2" |
| projectDocs/translating/admin.md | New documentation file for Crowdin administration procedures |
| .pre-commit-config.yaml | Migrated pyright hook from RobertCraigie/pyright-python repo to local uv-managed execution |
| .github/workflows/testAndPublish.yml | Updated actions/checkout from v5 to v6 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.