Skip to content

Conversation

@codeofdusk
Copy link
Contributor

Link to issue number:

Closes #19233.

Summary of the issue:

nemeth is unsuitable as a default MathCAT output code for NVDA's global user base (see #19233 for details).

Description of how this pull request fixes the issue:

Adds a new "automatic" Braille code config option and switched to it by default. This option:

  • Checks if there's a reasonable default code to use for the current NVDA language (es -> CMU, sv -> Swedish, vi -> Vietnamese);
  • Otherwise, falls back to ASCIIMath.

Testing strategy:

Changed NVDA language to Spanish and verified that CMU became the effective code when the Braille code option was set to auto.

Known issues with pull request:

None known

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses the issue where "Nemeth" was an unsuitable default MathCAT Braille code for NVDA's global user base. It introduces an "Automatic" Braille code option that selects an appropriate code based on the current NVDA language, with ASCIIMath as the fallback.

Key changes:

  • Adds automatic Braille code selection based on NVDA language (Spanish→CMU, Swedish→Swedish, Vietnamese→Vietnam, default→ASCIIMath)
  • Changes the default MathCAT Braille code from "Nemeth" to "Auto"
  • Updates the Math settings GUI to display the automatic option with the effective code shown in parentheses

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
source/buildVersion.py Bumps version from 2026.1 to 2026.2
user_docs/en/changes.md Adds placeholder sections for the 2026.2 release
source/config/configSpec.py Changes the default brailleCode from "Nemeth" to "Auto"
source/mathPres/MathCAT/preferences.py Implements getAutoBrailleCode() for language-based code selection and setEffectiveBrailleCode() to apply the effective code at runtime
source/mathPres/MathCAT/MathCAT.py Calls setEffectiveBrailleCode() during initialization to apply the effective Braille code
source/gui/settingsDialogs.py Updates the Math settings panel to show "Automatic" as the first option with the current effective code displayed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codeofdusk
Copy link
Contributor Author

CC @RyanMcCleary.

@seanbudd seanbudd added this to the 2026.1 milestone Dec 11, 2025
Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codeofdusk - generally looks good to me

@codeofdusk codeofdusk requested a review from a team as a code owner December 11, 2025 06:58
@seanbudd
Copy link
Member

Thanks @codeofdusk

@seanbudd seanbudd merged commit 6155d1d into nvaccess:beta Dec 11, 2025
41 checks passed
@codeofdusk codeofdusk mentioned this pull request Dec 11, 2025
5 tasks
seanbudd pushed a commit that referenced this pull request Dec 11, 2025
Follow-up of #19368.
Summary of the issue:

Portuguese usually uses the código matemático unificado (per the ONCE):

    ...la actualización del código matemático unificado, realizada por la Comisión Técnica de Ciencias del Consejo Iberoamericano del Braille.

Description of how this pull request fixes the issue:

Mapped pt_BR and pt_PT to CMU in the MathCAT auto table.
Testing strategy:

Verified mapping.
seanbudd pushed a commit that referenced this pull request Dec 15, 2025
Split from #19227. Follow-up of #19368.
Summary of the issue:

    The automatic Braille entry for Finnish was incorrect.
    Several languages could have more reasonable Braille defaults.

Description of how this pull request fixes the issue:

Simplify (key on base language only, not region codes), fix "fi", and expand Braille auto language table.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants