Skip to content

Conversation

@codeofdusk
Copy link
Contributor

Link to issue number:

Split from #19227. Follow-up of #19368.

Summary of the issue:

  • The automatic Braille entry for Finnish was incorrect.
  • Several languages could have more reasonable Braille defaults.

Description of how this pull request fixes the issue:

Simplify (key on base language only, not region codes), fix "fi", and expand Braille auto language table.

Testing strategy:

Braille mapping still functional.

Known issues with pull request:

None known

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

Copilot AI review requested due to automatic review settings December 12, 2025 10:44
@codeofdusk codeofdusk requested a review from a team as a code owner December 12, 2025 10:44
@codeofdusk codeofdusk requested a review from seanbudd December 12, 2025 10:44
@codeofdusk codeofdusk mentioned this pull request Dec 12, 2025
5 tasks
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes the automatic Braille entry for Finnish and simplifies the MathCAT Braille language mapping by focusing on base language codes rather than region-specific codes. It also expands the Braille auto language table with additional language mappings.

  • Corrected the Finnish Braille code from "ASCIIMath-finnish" to "ASCIIMath-fi"
  • Simplified language mapping to use base language codes only (e.g., "pt" instead of "pt_BR", "pt_PT")
  • Expanded the language-to-Braille code mapping table with 11 additional languages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codeofdusk

@seanbudd seanbudd changed the title Additional MathCAT Braille fixes Improve language handling for MathCAT braille Dec 15, 2025
@seanbudd seanbudd merged commit abdbd02 into nvaccess:beta Dec 15, 2025
45 of 50 checks passed
@github-actions github-actions bot added this to the 2026.2 milestone Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants