Notify user when connecting as follower fails#19454
Closed
tareh7z wants to merge 6 commits intonvaccess:masterfrom
Closed
Notify user when connecting as follower fails#19454tareh7z wants to merge 6 commits intonvaccess:masterfrom
tareh7z wants to merge 6 commits intonvaccess:masterfrom
Conversation
Contributor
Author
|
Hi! I think this PR, similar to PR #19442, could also be considered for the 2026.1 release. @seanbudd and @SaschaCowley, would you be able to review it? Thanks. |
Contributor
|
Hi, If targeting 2026.1, then the PR sould be based on origin/beta rather than origin/master as the master branch is targeting 2026.2 at the moment. Thanks. |
seanbudd
reviewed
Jan 19, 2026
| @@ -1,36 +0,0 @@ | |||
| # A part of NonVisual Desktop Access (NVDA) | |||
Member
There was a problem hiding this comment.
please make sure this file is restored rather than being deleted
Contributor
Author
5 tasks
seanbudd
pushed a commit
that referenced
this pull request
Jan 21, 2026
Replaces #19454 Replaces #19467 Fixes #19103 Summary of the issue: Users are not notified when connecting as the controlled computer (follower) fails. Only the leader connection errors are shown to users. Description of user facing changes: Users will now see an error message when connection as the controlled computer fails, just like when connecting as the controlling computer. Description of developer facing changes: None. Description of development approach: Made follower connection error handling consistent with leader connection by adding the missing event handler and user notification. Added onConnectAsFollowerFailed method in client.py to handle follower connection failures; Registered transportConnectionFailed event handler for follower transport; Added cleanup for event handlers in disconnectAsFollower method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #19103
Summary of the issue:
Users are not notified when connecting as the controlled computer (follower) fails. Only the leader connection errors are shown to users.
Description of user facing changes:
Users will now see an error message when connection as the controlled computer fails, just like when connecting as the controlling computer.
Description of developer facing changes:
None.
Description of development approach:
Made follower connection error handling consistent with leader connection by adding the missing event handler and user notification.
Testing strategy:
Tested manually.
Known issues with pull request:
None known.
Code Review Checklist: